Adjusting the ntp waiting time to a reasonable value#1052
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom Aug 2, 2019
Harrison-SH:pr3
Merged
Adjusting the ntp waiting time to a reasonable value#1052pavel-shirshov merged 1 commit intosonic-net:masterfrom Harrison-SH:pr3
pavel-shirshov merged 1 commit intosonic-net:masterfrom
Harrison-SH:pr3
Conversation
pavel-shirshov
approved these changes
Aug 2, 2019
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (sonic-net#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…on (sonic-net#3443) Submodule src/sonic-platform-common ac7fde6..58f9672: > [sfp_base] Raise exceptions (previously was incorrectly returning them) (sonic-net#61) Submodule src/sonic-swss 660530e..2974844: > Fix MIRROR_SESSION table macro name (sonic-net#802) > Don't try to remove a vxlan tunnel if it has associated tunnel maps (sonic-net#1052) Submodule src/sonic-swss-common d6140fa..d7b1f53: > Fix MIRROR_SESSION table macro name (sonic-net#264) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
Cherry-pick sonic-net#22679 to 202503 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: ``` Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs ``` console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? user can use different credential for console server. #### How did you do it? introduced new console_type, CONSOLE_SSH_TACACS #### How did you verify/test it? Verified locally. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Two turnkey limits for NTP: 128 ms for stepping and 500 ppm (496 to 512 ppm) for locking and slewing. So the maximum allowed offset of 128 ms will be compensated at maximum slewing rate of 512 ppm in a matter of 250 seconds (4.17 minutes). In practice, however, this will probably take slightly longer, as slewing rate is gradually decreased when approaching the target time.
At the same time. Even we used " ntpd -g". According to the actual testing result. We need to
Adjust the waiting time to 300. It is more reasonable.
Summary:
Fixes # (issue)
Type of change
Bug fix
Approach
changed roles/test/tasks/ntp.yml
How did you verify/test it?
passed ntp testcase.