[rdma] Skip certain PFC watchdog test cases#3443
Merged
neethajohn merged 4 commits intosonic-net:masterfrom May 11, 2021
Merged
[rdma] Skip certain PFC watchdog test cases#3443neethajohn merged 4 commits intosonic-net:masterfrom
neethajohn merged 4 commits intosonic-net:masterfrom
Conversation
baiwei0427
changed the title
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
neethajohn
approved these changes
May 5, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
PFC watchdog on Broadcom devices use some approximation techniques to detect PFC storms, which may cause some fake alerts (PFC watchdog is triggered though the length of PFC storm does not reach threshold). Therefore, we skip test cases whose trigger_pfcwd is False for Broadcom devices. Signed-off-by: Wei Bai webai@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Signed-off-by: Wei Bai webai@microsoft.com
Summary: Skip some PFC watchdog test cases
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
PFC watchdog on Broadcom devices use some approximation techniques to detect PFC storms, which may cause some fake alerts (PFC watchdog is triggered though the length of PFC storm does not reach threshold). Therefore, we skip test cases whose trigger_pfcwd is False for Broadcom devices.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation