add authtype for consoleserver#22679
Merged
wangxin merged 2 commits intosonic-net:masterfrom Mar 9, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
added
Request for msft-202503 Branch
Request for 202511 branch
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dashuai Zhang <[email protected]> # Conflicts: # tests/common/helpers/dut_utils.py
Signed-off-by: Dashuai Zhang <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Mar 7, 2026
This was referenced Mar 7, 2026
sdszhang
added
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
bingwang-ms
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Mar 9, 2026
Cherry-pick sonic-net/sonic-mgmt#22679 to 202503 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: ``` Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs ``` console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? user can use different credential for console server. #### How did you do it? introduced new console_type, CONSOLE_SSH_TACACS #### How did you verify/test it? Verified locally. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
sdszhang
added
Included in msft-202503 Branch
and removed
Cherry Pick Conflict_msft-202503
labels
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]>
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]> Signed-off-by: Mihut Aronovici <[email protected]>
Collaborator
|
@sdszhang PR conflicts with 202511 branch |
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 14, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]>
4 tasks
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]> Signed-off-by: selldinesh <[email protected]>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 17, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]> Signed-off-by: Abhishek <[email protected]>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
support specifying authentication credential choice for console server (e.g. TACACS or AAD),
With the following device:
console-1 will use the default credentials in secrets.yaml "console_login".
console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']"
Type of change
Back port request
Approach
What is the motivation for this PR?
user can use different credential for console server.
How did you do it?
introduced new console_type, CONSOLE_SSH_TACACS
How did you verify/test it?
Verified locally.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation