[docker-platform-monitor] add psud daemon to Pmon

[kevinwangsk]

Signed-off-by: Kevin Wang [email protected]

- What I did
Add new psud daemon to Pmon container.
- How I did it
Wrap psud daemon to a deb package.
Add psud daemon into the supervisor configuration.
Add psud daemon into Pmon container.
- How to verify it
After the board is up, check if there is the psud process is running.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[jleveque]

As comments, plus please update the sonic-platform-daemons submodule in order to incorporate psud into the image.

[liat-grozovik]

I am unable to comment on sonic-psud/scripts/psud so i am placing my comments below
sonic-psud/scripts/psud

1. General question: what is the purpose of version and what happens when version number is changed?
2. Line #4: please use psud and not Psud
3. Line #42-44 I believe this is not the first time we have REDIS_XXX definition. Do we have many places for defining it? Why not create a single place? I believe you will need it also for all the rest of the daemons in pmon.
4. Same comment for log functions. Why they are different from one daemon to another? I believe some input param should to the trick for all daemons in pmon
5. Line #166 can stat_db be null? Should you verify and place error handling?
6. Line #171 what is the logic behind chassis_tbl? Should it read only once in system life cycle?
7. Line #172 can the num_psu changed during the system live? How you handle PSU taken out?
8. Line #179 Can psu_db_update fails? I see no error handling
9. Line #186: no need for double Error “log_error("Error: return error from psu daemon, exiting...")”

[kevinwangsk]

For 1st. version is a tag of this package. There should be a command in Setuptools package to show the version history.
For 6th. Yes, it should be read only once every field has been set well in chassis_tbl. The question is where to set all the fields. As it is involved from the new platform API, current no logic to cover it. From my point of view, each daemon should set the related fields of chassis_tbl by themselves.
For 7th. Not sure the other platforms. But on MLNX platform, num_psu will not change during system live. If PSU is taken out, there is a file in Sysfs will indicate the "precense" is "0" of this PSU.

For other comments, such as comments correction, logging, error handling, I think it should be more likely an improvement task for all the daemons in sonic-platform-daemon repo. It is good for improving the robustness of the daemons, but I would suggest covering those items in a separate commit as the purpose of this commit is just to add the PSU daemon.