[device/centec] Replace os.system and remove subprocess with shell=True

[maipbui]

Signed-off-by: maipbui maibui@microsoft.com

Why I did it

subprocess.Popen() and subprocess.run() is used with shell=True, which is very dangerous for shell injection.
os - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content

How I did it

Replace os by subprocess, remove shell=True
Remove unused functions

How to verify it

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[qiluo-msft]

502

Do you miss the trailing new line? #Closed

[maipbui]

I added \n, thank you.

[maipbui]

/azp run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qiluo-msft]

@LuiSzee @guxianghong @taochengyi @yangbashuang
Could you help review and verify?

[guxianghong]

@LuiSzee @guxianghong @taochengyi @yangbashuang Could you help review and verify?

Ok, we will review and verify it on centec platform.

[LuiSzee]

subprocess.run not work on older version SONiC image, such as 201911

Python 2.7.17 (default, Jul  1 2022, 15:56:32)
[GCC 7.5.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import subprocess
>>> subprocess.run('sleep', '1')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'run'

[maipbui]

subprocess.run not work on older version SONiC image, such as 201911

Python 2.7.17 (default, Jul  1 2022, 15:56:32)
[GCC 7.5.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import subprocess
>>> subprocess.run('sleep', '1')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'run'

@LuiSzee I changed it to subprocess.call(), thanks for your feedback.

[maipbui]

@LuiSzee @guxianghong @taochengyi @yangbashuang Do you have any further comments?

[LuiSzee]

@maipbui I have verified it on centec platform.