Dell SMF driver hwmon number reorder fix for Dell S6100/Z9100#2306
Closed
paavaanan wants to merge 1 commit intosonic-net:201803from
Closed
Dell SMF driver hwmon number reorder fix for Dell S6100/Z9100#2306paavaanan wants to merge 1 commit intosonic-net:201803from
paavaanan wants to merge 1 commit intosonic-net:201803from
Conversation
Contributor
|
This appears to be a duplicate of #2305. Why two duplicate PRs? |
Contributor
Author
|
This fix is raised for March Branch... |
Contributor
|
Since the changes are identical between both branches, we don't need two separate PRs. We can merge the other one into the master branch and then cherry-pick that commit into the March branch. This prevents the need to review 2 PRs and creates less room for error if the PRs drift. I recommend closing this PR and working with #2305 only. |
Contributor
Author
|
Thanks Joe! |
Contributor
Author
|
re-opened the PR to merge this fix in March Branch |
Contributor
|
Retest this please. |
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 2, 2022
Including change: * 7ff8f75 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)" (sonic-net#2306) (HEAD -> 202205, github/202205) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
6 tasks
yxieca
added a commit
that referenced
this pull request
Jun 2, 2022
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 8, 2022
To included: * ad8f5e4 2022-06-08 | Revert "[Counters] Improve performance by polling only configured ports buffer queue/pg counters (sonic-net#2143)" (sonic-net#2315) (HEAD -> master, origin/master, origin/HEAD) [Ying Xie] * 2ff763f 2022-06-08 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) [Vaibhav Hemant Dixit] * 05d19ea 2022-06-02 | Purge package sonic-db-cli which depends on libswsscommon (sonic-net#2308) [Qi Luo] * a0c3238 2022-06-03 | Add port counter sanity check (sonic-net#2300) [Junhua Zhai] * 4944f0f 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)" (sonic-net#2306) [bingwang-ms] * eba212d 2022-05-31 | [Counters] Improve performance by polling only configured ports buffer queue/pg counters (sonic-net#2143) [shlomibitton] * 9999dae 2022-05-28 | [counter] Support gearbox counters (sonic-net#2218) [Junhua Zhai] * c73cf10 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (sonic-net#2234) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 9, 2022
To included: * ad8f5e4 2022-06-08 | Revert "[Counters] Improve performance by polling only configured ports buffer queue/pg counters (#2143)" (#2315) (HEAD -> master, origin/master, origin/HEAD) [Ying Xie] * 2ff763f 2022-06-08 | Fix test_warm_reboot issues blocking PR merge (#2309) [Vaibhav Hemant Dixit] * 05d19ea 2022-06-02 | Purge package sonic-db-cli which depends on libswsscommon (#2308) [Qi Luo] * a0c3238 2022-06-03 | Add port counter sanity check (#2300) [Junhua Zhai] * 4944f0f 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165)" (#2306) [bingwang-ms] * eba212d 2022-05-31 | [Counters] Improve performance by polling only configured ports buffer queue/pg counters (#2143) [shlomibitton] * 9999dae 2022-05-28 | [counter] Support gearbox counters (#2218) [Junhua Zhai] * c73cf10 2022-05-28 | Support mock_test infra for dynamic buffer manager and fix issues found during mock test (#2234) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
robertvolkmann
pushed a commit
to robertvolkmann/sonic-buildimage
that referenced
this pull request
Jul 26, 2022
Including change: * 7ff8f75 2022-06-03 | Revert "[portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)" (sonic-net#2306) (HEAD -> 202205, github/202205) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
…ctive ACL binding (sonic-net#2165)" (sonic-net#2306) This reverts commit 390cae1.
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Oct 20, 2022
aedc05e [QoS] Support dynamic headroom calculation for Barefoot platforms (sonic-net#2306) 7f4da26 [app_ext] [auto-ts] Add available_mem_threshold option (sonic-net#2423) b250701 YANG Validation for ConfigDB Updates: Fix Decorator Bug (sonic-net#2405) f62d1e5 [watermarkstat] Add new warning message for the 'q_shared_multi' counters (sonic-net#2408) 25fda26 [chassis]Add fabric counter cli commands (sonic-net#1860) ae97e59 Update sonic command doc to add CLIs relative to SONiC fips (sonic-net#2377) abd5eba [generate_dump]: Enhance show techsupport for cisco-8000 platform (sonic-net#2403) ee15b74 Include configuring laser frequency and tx power (sonic-net#2437) 70be50c Add a subcommand to display a hexdump of transceiver EEPROM page (sonic-net#2379) c246801 Filter port invalid MTU configuration (sonic-net#2378) 362ec9b [show] vnet advertised-route command (sonic-net#2390) 2372e29 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#2386) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Oct 23, 2022
aedc05e [QoS] Support dynamic headroom calculation for Barefoot platforms (#2306) 7f4da26 [app_ext] [auto-ts] Add available_mem_threshold option (#2423) b250701 YANG Validation for ConfigDB Updates: Fix Decorator Bug (#2405) f62d1e5 [watermarkstat] Add new warning message for the 'q_shared_multi' counters (#2408) 25fda26 [chassis]Add fabric counter cli commands (#1860) ae97e59 Update sonic command doc to add CLIs relative to SONiC fips (#2377) abd5eba [generate_dump]: Enhance show techsupport for cisco-8000 platform (#2403) ee15b74 Include configuring laser frequency and tx power (#2437) 70be50c Add a subcommand to display a hexdump of transceiver EEPROM page (#2379) c246801 Filter port invalid MTU configuration (#2378) 362ec9b [show] vnet advertised-route command (#2390) 2372e29 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#2386) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vadymhlushko-mlnx
pushed a commit
to vadymhlushko-mlnx/sonic-buildimage
that referenced
this pull request
Nov 11, 2022
…nic-net#2306) Signed-off-by: Mariusz Stachura <mariusz.stachura@intel.com> What I did Adding the dynamic headroom calculation support for Barefoot platforms. Why I did it Enabling dynamic mode for barefoot case. How I verified it The community tests are adjusted and pass.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Dell SMF driver initialiation with hwmon support changes from hwmon0 to hwmon1. This happens when Ingrasys enabled coretemp kernel driver. At the time of coretemp initalization with hwmon it allocates handle [hwmon0] to intel coretemp. Due to non-availablity next order [hwmon1] is alloted to SMF driver.
This order changes affects the existing scripts which rely on existing numerbing scheme.
- How I did it
- How to verify it