Add flag to enable cudf.pandas with CLI#6364
Add flag to enable cudf.pandas with CLI#6364dantegd wants to merge 2 commits intorapidsai:branch-25.04from
Conversation
dantegd
added
feature request
| # Support invoking run_cuml_singlegpu_pytests.sh outside the script directory | ||
| cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../python/cuml/cuml/tests | ||
|
|
||
| python -m pytest -p cudf.pandas -p cuml.experimental.accel --cache-clear "$@" experimental/accel/ |
There was a problem hiding this comment.
For the cuml.accel tests in run_cuml_singlegpu_accel_pytests.sh we cd into the experimental/accel directory. Can we keep it consistent? Not sure but maybe it effects the paths we see in the logs?
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
I think for now this is good, but we should look at how we do CI and testing more holistically.
|
/merge |
PRs being backported: - [x] #6234 - [x] #6306 - [x] #6320 - [x] #6319 - [x] #6327 - [x] #6333 - [x] #6142 - [x] #6223 - [x] #6235 - [x] #6317 - [x] #6331 - [x] #6326 - [x] #6332 - [x] #6347 - [x] #6348 - [x] #6337 - [x] #6355 - [x] #6354 - [x] #6322 - [x] #6353 - [x] #6359 - [x] #6364 - [x] #6363 - [x] [FIL BATCH_TREE_REORG fix for SM90, 100 and 120](a3e419a) --------- Co-authored-by: William Hicks <whicks@nvidia.com>
|
Just like how we can stack accelerators in pytest with Likewise, the recommended way of loading both accelerators in a notebook is to load both extensions (in either order) With some recent changes, this almost works as intended today. Unfortunately there's a bug in the CLI where stacking only works if # Fails
python -m cuml.accel -m cudf.pandas myscript.py
# Succeeds
python -m cudf.pandas -m cuml.accel myscript.pyI'll push a fix up for that, but think we should drop this PR since a custom flag doesn't compose nearly as well. Closing as stale and (IMO) no longer desired. If you disagree feel free to reopen. |
|
Gah, just noticed this was merged into the backport but never actually merged into dev. Then after the backport was forward merged into the new branch this was added back into dev but not through this PR. Shenanigans. Anyway, I'll still push the fix up I mentioned above, and might advocate for deprecating the flag in favor of composing |
4 participants
Adds flag to enable cudf.pandas to experimental CLI UX