Correct translation of RandomForest criterion hyperparameter#6363
Correct translation of RandomForest criterion hyperparameter#6363rapids-bot[bot] merged 12 commits intorapidsai:branch-25.04from
Conversation
| "criterion": "NotImplemented", | ||
| "criterion": { | ||
| "friedman_mse": "NotImplemented", | ||
| "absolute_error": "NotImplemented", |
There was a problem hiding this comment.
| "absolute_error": "NotImplemented", | |
| "absolute_error": "NotImplemented", | |
| "squared_error": "mse", |
So that RandomForestRegressor() and RandomForestRegressor(criterion="squared_error") both work. Explicitly passing the constructor arg's default value might happen during grid searching
There was a problem hiding this comment.
Check out the latest implementation. I think this may have been based on 4c8a80b, but the original intent was that this translation should not be necessary. I believe that is true in the current implementation.
|
Just to double check: if the user passes |
|
Deleted the merge comment because I think 4c8a80b broke this functionality. Want to make sure we take a closer look before proceeding. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Approving in case we just want to merge it (logic looks correct). Noted two small nits in the implementation, leaving it up to you if you want to address them or not.
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Logic looks fine to me. I did not check whether the actual mapping of supported criteria is correct.
|
/merge |
PRs being backported: - [x] #6234 - [x] #6306 - [x] #6320 - [x] #6319 - [x] #6327 - [x] #6333 - [x] #6142 - [x] #6223 - [x] #6235 - [x] #6317 - [x] #6331 - [x] #6326 - [x] #6332 - [x] #6347 - [x] #6348 - [x] #6337 - [x] #6355 - [x] #6354 - [x] #6322 - [x] #6353 - [x] #6359 - [x] #6364 - [x] #6363 - [x] [FIL BATCH_TREE_REORG fix for SM90, 100 and 120](a3e419a) --------- Co-authored-by: William Hicks <whicks@nvidia.com>
6 participants
No description provided.