Fix output type of KernelRidge.predict#6354
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from Feb 23, 2025
Merged
Fix output type of KernelRidge.predict#6354rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from
KernelRidge.predict#6354rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from
Conversation
Previously this wasn't handled correctly, but was _sometimes_ masked by `GridSearchCV` in the old test fixing things behind the scenes. This fixes that, adds a test that doesn't require the accelerator, and changes the accelerator test to be both simpler (matching the smoketests in the rest of the file) and much faster (the `GridSearchCV` in the test made the test quite slow on my machine).
jcrist
added
bug
dantegd
approved these changes
Feb 23, 2025
Member
|
/merge |
24 tasks
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 23, 2025
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 26, 2025
raydouglass
pushed a commit
that referenced
this pull request
Feb 28, 2025
PRs being backported: - [x] #6234 - [x] #6306 - [x] #6320 - [x] #6319 - [x] #6327 - [x] #6333 - [x] #6142 - [x] #6223 - [x] #6235 - [x] #6317 - [x] #6331 - [x] #6326 - [x] #6332 - [x] #6347 - [x] #6348 - [x] #6337 - [x] #6355 - [x] #6354 - [x] #6322 - [x] #6353 - [x] #6359 - [x] #6364 - [x] #6363 - [x] [FIL BATCH_TREE_REORG fix for SM90, 100 and 120](a3e419a) --------- Co-authored-by: William Hicks <whicks@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this wasn't handled correctly, but was sometimes masked by
GridSearchCVin the old test fixing things behind the scenes.This fixes the bug, adds a test that doesn't require the accelerator, and changes the accelerator test to be both simpler (matching the smoketests in the rest of the file) and much faster (the
GridSearchCVin the test made the test quite slow on my machine).Fixup to the fix applied in #6327.