Adjust accel verbosity#6353
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.04from Feb 24, 2025
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
added
improvement
24 tasks
dantegd
reviewed
Feb 23, 2025
Member
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
Change looks good, just one comment
| default="converted_sklearn_model.pkl", | ||
| help="Output path for the converted sklearn estimator file.", | ||
| ) | ||
| @click.option("-v", "--verbose", count=True) |
Member
There was a problem hiding this comment.
I'd recommend adding a help message that maps the numbers of v to what logger_level is set
csadorf
force-pushed
the
adjust-accel-verbosity
branch
from
8f3f905 to
d38f1e1
Compare
wphicks
approved these changes
Feb 24, 2025
wphicks
approved these changes
Feb 24, 2025
Contributor
Author
|
/merge |
Contributor
Author
|
/merge |
1 similar comment
Contributor
Author
|
/merge |
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 25, 2025
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 26, 2025
raydouglass
pushed a commit
that referenced
this pull request
Feb 28, 2025
PRs being backported: - [x] #6234 - [x] #6306 - [x] #6320 - [x] #6319 - [x] #6327 - [x] #6333 - [x] #6142 - [x] #6223 - [x] #6235 - [x] #6317 - [x] #6331 - [x] #6326 - [x] #6332 - [x] #6347 - [x] #6348 - [x] #6337 - [x] #6355 - [x] #6354 - [x] #6322 - [x] #6353 - [x] #6359 - [x] #6364 - [x] #6363 - [x] [FIL BATCH_TREE_REORG fix for SM90, 100 and 120](a3e419a) --------- Co-authored-by: William Hicks <whicks@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
-v/--verboseoption to the accel entrypoint and adjusts log verbosity and messages during accel installation.Follow-up for #6348