fix: migrate integration tests from paseo to polkadot runtimes#201
Merged
chungquantin merged 14 commits intochungquantin/chore-polkadot-v1.14.0from Aug 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## chungquantin/chore-polkadot-v1.14.0 #201 +/- ##
===================================================================
Coverage 6.40% 6.40%
===================================================================
Files 27 27
Lines 1997 1997
Branches 1997 1997
===================================================================
Hits 128 128
Misses 1869 1869 |
paseo to polkadot runtimes
…fix-current_integration_tests
…fix-current_integration_tests
Daanvdplas
reviewed
Aug 20, 2024
Collaborator
Daanvdplas
left a comment
There was a problem hiding this comment.
Mainly questions but would be good if @evilrobot-01 can take a quick look.
evilrobot-01
requested changes
Aug 20, 2024
Collaborator
evilrobot-01
left a comment
There was a problem hiding this comment.
Great on the whole, needs a few fixes tho please.
Contributor
Author
|
@evilrobot-01 Thanks for your review, Frank. After re-reviewing my own code, I decided to do dependency alias instead so we can get rid of all the unnecessary changes related to crate name. Please help me to review it again! |
evilrobot-01
approved these changes
Aug 20, 2024
Collaborator
evilrobot-01
left a comment
There was a problem hiding this comment.
A pleasure to review, super clean thanks to the manifest aliases, well done!
al3mart
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
transfer_assets_delivery_feestoteleport_assets_delivery_fees.Withdrawevent withBurnedandDepositevent withMinted