Skip to content

fix: migrate integration tests from paseo to polkadot runtimes#201

Merged
chungquantin merged 14 commits intochungquantin/chore-polkadot-v1.14.0from
chungquantin/fix-current_integration_tests
Aug 20, 2024
Merged

fix: migrate integration tests from paseo to polkadot runtimes#201
chungquantin merged 14 commits intochungquantin/chore-polkadot-v1.14.0from
chungquantin/fix-current_integration_tests

Conversation

@chungquantin
Copy link
Contributor

@chungquantin chungquantin commented Aug 16, 2024

CHANGELOG

  • Migrate the Paseo runtimes to Polkadot runtimes as a stopgap until Paseo is updated to v1.14.0.
  • Replace deprecated method transfer_assets_delivery_fees to teleport_assets_delivery_fees.
  • Replace Withdraw event with Burned and Deposit event with Minted

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.40%. Comparing base (c42114c) to head (a70a293).
Report is 1 commits behind head on chungquantin/chore-polkadot-v1.14.0.

@@                         Coverage Diff                         @@
##           chungquantin/chore-polkadot-v1.14.0    #201   +/-   ##
===================================================================
  Coverage                                 6.40%   6.40%           
===================================================================
  Files                                       27      27           
  Lines                                     1997    1997           
  Branches                                  1997    1997           
===================================================================
  Hits                                       128     128           
  Misses                                    1869    1869           

@chungquantin chungquantin changed the title fix: current integration tests fix: migrate integration tests from paseo to polkadot runtimes Aug 17, 2024
@chungquantin chungquantin self-assigned this Aug 17, 2024
@chungquantin chungquantin mentioned this pull request Aug 20, 2024
3 tasks
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly questions but would be good if @evilrobot-01 can take a quick look.

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great on the whole, needs a few fixes tho please.

@chungquantin
Copy link
Contributor Author

@evilrobot-01 Thanks for your review, Frank. After re-reviewing my own code, I decided to do dependency alias instead so we can get rid of all the unnecessary changes related to crate name. Please help me to review it again!

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pleasure to review, super clean thanks to the manifest aliases, well done!

@chungquantin chungquantin merged commit 83405b4 into chungquantin/chore-polkadot-v1.14.0 Aug 20, 2024
@chungquantin chungquantin deleted the chungquantin/fix-current_integration_tests branch August 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants