Skip to content

fix epmb solution duplicate issue + add remote mining apparatus to epm#8585

Merged
kianenigma merged 20 commits intomasterfrom
kiz-ep-fix-duplicate
May 21, 2025
Merged

fix epmb solution duplicate issue + add remote mining apparatus to epm#8585
kianenigma merged 20 commits intomasterfrom
kiz-ep-fix-duplicate

Conversation

@kianenigma
Copy link
Copy Markdown
Contributor

@kianenigma kianenigma commented May 20, 2025

Backports a part of #8422 to master so it can be included in ongoing releases sooner.

@kianenigma kianenigma requested a review from a team as a code owner May 20, 2025 23:39
@kianenigma
Copy link
Copy Markdown
Contributor Author

kianenigma commented May 20, 2025

/cmd prdoc --bump patch

@kianenigma kianenigma mentioned this pull request May 20, 2025
Merged
9 tasks
kianenigma
kianenigma commented May 21, 2025
View reviewed changes
substrate/frame/election-provider-multi-block/src/unsigned/miner.rs
],
vec![
(30, Support { total: 11, voters: vec![(7, 7), (5, 2), (6, 2)] }),
(30, Support { total: 11, voters: vec![(5, 2), (6, 2), (7, 7)] }),
Copy link
Copy Markdown
Contributor Author

@kianenigma kianenigma May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these ordering changes are irrelevant -- the order within Support doesn't matter.

kianenigma
kianenigma commented May 21, 2025
View reviewed changes
substrate/frame/election-provider-multi-phase/src/remote_mining.rs
}

#[tokio::test]
async fn mine_for_polkadot() {
Copy link
Copy Markdown
Contributor Author

@kianenigma kianenigma May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used this to test that the new check indeed doesn't cause anything to fail on a few recent staking elections on polkadot and kusama.

@kianenigma kianenigma added the T2-pallets This PR/Issue is related to a particular pallet. label May 21, 2025
@kianenigma kianenigma requested review from Ank4n and seadanda May 21, 2025 10:09
seadanda
seadanda approved these changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible high level, but I'm not a domain expert

@kianenigma kianenigma enabled auto-merge May 21, 2025 10:33
@kianenigma kianenigma added the A4-backport-stable2503 Pull request must be backported to the stable2503 release branch label May 21, 2025
kianenigma
kianenigma commented May 21, 2025
View reviewed changes
@paritytech-workflow-stopper
Copy link
Copy Markdown

paritytech-workflow-stopper bot commented May 21, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15162654049
Failed job name: test-linux-stable-no-try-runtime

@athei
Copy link
Copy Markdown
Member

athei commented May 21, 2025

I think those are flaky, too:

  TRY 1 SLOW [>2040.000s] sc-consensus-babe tests::rejects_missing_seals
  TRY 1 SLOW [>2040.000s] sc-network-test sync::sync_to_tip_when_we_sync_together_with_multiple_peers

@kianenigma kianenigma added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 5d71d47 May 21, 2025
236 of 245 checks passed
@kianenigma kianenigma deleted the kiz-ep-fix-duplicate branch May 21, 2025 16:04
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented May 21, 2025

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8585-to-stable2412
git worktree add --checkout .worktree/backport-8585-to-stable2412 backport-8585-to-stable2412
cd .worktree/backport-8585-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 5d71d474ab78dacc37f89698a71baa45b41d0302
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request May 21, 2025
Merged
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented May 21, 2025

Created backport PR for stable2503:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8585-to-stable2503
git worktree add --checkout .worktree/backport-8585-to-stable2503 backport-8585-to-stable2503
cd .worktree/backport-8585-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 5d71d474ab78dacc37f89698a71baa45b41d0302
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request May 21, 2025
Merged
EgorPopelyaev pushed a commit that referenced this pull request May 21, 2025
@paritytech-release-backport-bot @kianenigma
[stable2412] Backport #8585 (#8601)
9e64443 
Backport #8585 into `stable2412` from kianenigma.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: kianenigma <[email protected]>
EgorPopelyaev added a commit that referenced this pull request May 22, 2025
@paritytech-release-backport-bot @kianenigma @EgorPopelyaev
[stable2503] Backport #8585 (#8602)
1158a21 
Backport #8585 into `stable2503` from kianenigma.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: kianenigma <[email protected]>
Co-authored-by: Egor_P <[email protected]>
ordian added a commit that referenced this pull request May 27, 2025
@ordian
Merge branch 'master' into ao-fix-issue-64
67a1bfe 
* master: (99 commits)
  Snowbridge: Remove asset location check for compatibility (#8473)
  add poke_deposit extrinsic to pallet-bounties (#8382)
  litep2p/peerset: Reject non-reserved peers in the reserved-only mode (#8650)
  Charge deposit based on key length (#8648)
  [pallet-revive] make subscription task panic on error (#8587)
  tx/metrics: Add metrics for the RPC v2 `transactionWatch_v1_submitAndWatch` (#8345)
  Bridges: Fix - Improve try-state for pallet-xcm-bridge-hub (#8615)
  Introduce CreateBare, deprecated CreateInherent (#7597)
  Use hashbrown hashmap/hashset in validation context (#8606)
  ci: rm gitlab config (#8622)
  🔪 flaky and Zombienet tests (#8600)
  cumulus: adjust unincluded segment size metric buckets (#8617)
  Benchmark storage access on block validation (#8069)
  Revert 7934 es/remove tj changes (#8611)
  collator-protocol: add more collation observability (#8230)
  `fatxpool`: add fallback for ready at light (#8533)
  txpool: fix tx removal from unlocks set (#8500)
  XCMP weight metering: account for the MQ page position (#8344)
  fix epmb solution duplicate issue + add remote mining apparatus to epm (#8585)
  Fix generated address returned by Substrate RPC runtime call (#8504)
  ...
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2025
@kianenigma @acatangiu
@github-actions @sigurpol
[AHM] Staking async fixes for XCM and election planning (#8422)
7bb570d 
This PR brings a few small fixes related to the XCM messages of
staking-async, among other small fixes:


* [x] Allows `xcm::validate` to check the message size, and we actually
now act upon it in the `staking-async-rc/parachain-runtime`s. The code
is a bit duplicate now, and there is a TOOD about how to better refactor
it later.
* [x] Part of this work is backported separately as
#8409
* [x] It brings a default `EraElectionPlannerOf` which should be the
right tool to use to ensure elections always happen in time, with an
educated guess based on `ElectionProvider::duration` rather than a
random number.
* [x] It adds a few unit tests about the above
* [x] It silences some logs that were needlessly `INFO`, and makes the
printing of some types a bit more CLI friendly.
* [x] Fix the issue with duplicate voters in solution type: see
#8585
* [x] Move `PagedRawSolution` to be unbounded, and therefore decode-able
without PoV
* [x] Undo a rename from `ClaimedRewards` to `ErasClaimedRewards`
  * [ ] Needs fixing in westend

---------

Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paolo La Camera <[email protected]>
@seadanda seadanda mentioned this pull request Jun 4, 2025
Merged
7 tasks
pgherveou pushed a commit that referenced this pull request Jun 11, 2025
@kianenigma @acatangiu
@github-actions @sigurpol @pgherveou
[AHM] Staking async fixes for XCM and election planning (#8422)
80ff238 
This PR brings a few small fixes related to the XCM messages of
staking-async, among other small fixes:


* [x] Allows `xcm::validate` to check the message size, and we actually
now act upon it in the `staking-async-rc/parachain-runtime`s. The code
is a bit duplicate now, and there is a TOOD about how to better refactor
it later.
* [x] Part of this work is backported separately as
#8409
* [x] It brings a default `EraElectionPlannerOf` which should be the
right tool to use to ensure elections always happen in time, with an
educated guess based on `ElectionProvider::duration` rather than a
random number.
* [x] It adds a few unit tests about the above
* [x] It silences some logs that were needlessly `INFO`, and makes the
printing of some types a bit more CLI friendly.
* [x] Fix the issue with duplicate voters in solution type: see
#8585
* [x] Move `PagedRawSolution` to be unbounded, and therefore decode-able
without PoV
* [x] Undo a rename from `ClaimedRewards` to `ErasClaimedRewards`
  * [ ] Needs fixing in westend

---------

Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paolo La Camera <[email protected]>
alstjd0921 pushed a commit to bifrost-platform/polkadot-sdk that referenced this pull request Aug 14, 2025
@paritytech-release-backport-bot @kianenigma
@EgorPopelyaev @alstjd0921
[stable2503] Backport paritytech#8585 (paritytech#8602)
e2e6c2b 
Backport paritytech#8585 into `stable2503` from kianenigma.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: kianenigma <[email protected]>
Co-authored-by: Egor_P <[email protected]>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@kianenigma @github-actions
@seadanda @alvicsam
fix epmb solution duplicate issue + add remote mining apparatus to epm (
f628e8c 
#8585)

Backports a part of #8422
to master so it can be included in ongoing releases sooner.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dónal Murray <[email protected]>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@kianenigma @acatangiu
@github-actions @sigurpol @alvicsam
[AHM] Staking async fixes for XCM and election planning (#8422)
0f47934 
This PR brings a few small fixes related to the XCM messages of
staking-async, among other small fixes:


* [x] Allows `xcm::validate` to check the message size, and we actually
now act upon it in the `staking-async-rc/parachain-runtime`s. The code
is a bit duplicate now, and there is a TOOD about how to better refactor
it later.
* [x] Part of this work is backported separately as
#8409
* [x] It brings a default `EraElectionPlannerOf` which should be the
right tool to use to ensure elections always happen in time, with an
educated guess based on `ElectionProvider::duration` rather than a
random number.
* [x] It adds a few unit tests about the above
* [x] It silences some logs that were needlessly `INFO`, and makes the
printing of some types a bit more CLI friendly.
* [x] Fix the issue with duplicate voters in solution type: see
#8585
* [x] Move `PagedRawSolution` to be unbounded, and therefore decode-able
without PoV
* [x] Undo a rename from `ClaimedRewards` to `ErasClaimedRewards`
  * [ ] Needs fixing in westend

---------

Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paolo La Camera <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@Ank4n Ank4n Ank4n approved these changes

@seadanda seadanda seadanda approved these changes

Assignees

No one assigned

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch T2-pallets This PR/Issue is related to a particular pallet.

Projects

[preview] release tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kianenigma @athei @franciscoaguirre @Ank4n @seadanda @pgherveou