[AHM] Staking async fixes for XCM and election planning by kianenigma · Pull Request #8422 · paritytech/polkadot-sdk

kianenigma · 2025-05-05T09:05:33Z

This PR brings a few small fixes related to the XCM messages of staking-async, among other small fixes:

Allows xcm::validate to check the message size, and we actually now act upon it in the staking-async-rc/parachain-runtimes. The code is a bit duplicate now, and there is a TOOD about how to better refactor it later.
Part of this work is backported separately as check XCM size in VMP routing #8409
It brings a default EraElectionPlannerOf which should be the right tool to use to ensure elections always happen in time, with an educated guess based on ElectionProvider::duration rather than a random number.
It adds a few unit tests about the above
It silences some logs that were needlessly INFO, and makes the printing of some types a bit more CLI friendly.
Fix the issue with duplicate voters in solution type: see fix epmb solution duplicate issue + add remote mining apparatus to epm #8585
Move PagedRawSolution to be unbounded, and therefore decode-able without PoV
Undo a rename from ClaimedRewards to ErasClaimedRewards
- Needs fixing in westend

kianenigma · 2025-05-05T09:05:57Z

\cmd prdoc --bump minor

substrate/frame/staking-async/runtimes/parachain/src/lib.rs

substrate/frame/staking-async/runtimes/parachain/src/staking.rs

substrate/frame/staking-async/runtimes/rc/src/lib.rs

substrate/frame/staking-async/src/lib.rs

Co-authored-by: Adrian Catangiu <adrian@parity.io>

…staking-async-xcm-weight

kianenigma · 2025-05-05T13:03:52Z

/cmd prdoc --bump minor

…staking-async-xcm-weight

…d now allow page count to be in storage

substrate/frame/staking-async/runtimes/parachain/src/staking.rs

#8585) Backports a part of #8422 to master so it can be included in ongoing releases sooner. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>

kianenigma · 2025-05-22T10:55:55Z

substrate/frame/staking-async/rc-client/src/lib.rs

+}
+
+/// Common utility to send XCM messages that can use [`SplittableMessage`].
+pub struct XCMSender<Sender, Destination, Message, ToXcm>(


@franciscoaguirre @acatangiu I tried to be smart here and refactor the XCM sending facility in both RC and AH into one type, but I now realize that this has a downside that it is binding both to use the same xcm types, aka v5. This will be an issue right? or do we update XCM versions across system chains in sync?

@franciscoaguirre @acatangiu I tried to be smart here and refactor the XCM sending facility in both RC and AH into one type, but I now realize that this has a downside that it is binding both to use the same xcm types, aka v5. This will be an issue right? or do we update XCM versions across system chains in sync?

@kianenigma all the xcm/xcm-builder stuff/tooling is using latest XCM version. Are you using any specific instruction from XCMv5? If not then, the different XCM version on different chains shouldn't be an issue, because at the end you are sending the XCM with Sender: SendXcm implementation which I guess it would be either struct ParentAsUmp or struct ChildParachainRouter, and they both are doing wrap_version to VersionedXcm according to the known XCM versions of receiving chain.

The only thing, if you are using xcm::v5::Transact and just to be sure, you need to set fallback_max_weight: Some(...), - in case it will go to the chain with just XCMv4

and also with 1.5.1 release all the system+relay chains got XCMv5, so there shouldn't be any issue with XCM vesrions between relaychain and AHs

Thanks for the info @bkontur!

We are indeed using Transact, and atm I am setting fallback_max_weight to None.

This type is only intended to be used between RC <> AH, so version mismatch will not be an issue.

I conclude that:

within this PR, we are good

what I need to do to ace this is to have emulator tests in the fellowship runtimes that ensures these XCMs can always be sent between RC <> AH of polkadot and kusama.

…staking-async-xcm-weight

…polkadot-sdk into kiz-staking-async-xcm-weight

bkontur · 2025-05-29T10:05:04Z

substrate/frame/staking-async/rc-client/src/lib.rs

+			{
+				Ok((_ticket, price)) => {
+					log::debug!(target: "runtime::staking-async::xcm", "📨 validated, price: {:?}", price);
+					return Ok(current_messages.into_iter().map(ToXcm::convert).collect::<Vec<_>>());


I'm not sure if I understand this correctly. At first, you're trying to validate whether it's okay to send just one message using first_xcm = ToXcm::convert(current_messages.first()). If the validation succeeds, you then return all the current_messages, not just the one that was validated?
I think this isn't fully compliant with the SendXcm trait's description. According to it, the ticket returned by SendXcm::validate should be passed to SendXcm::deliver.

Or is this kind of "best effort" strategy? Validate at least first one and then try to send more and just log errors when they fail?

Great catch! this goes back to

// the first message is the heaviest, the last one might be smaller.

In that our only concern here is the size. And the first message is always the largest. All the rest are equal or smaller, so if the first one is validated, we should be good.

I think this isn't fully compliant with the SendXcm trait's description. According to it, the ticket returned by SendXcm::validate should be passed to SendXcm::deliver.

I am sort of skipping this, as I am dropping ticket in this scope. Laster on, when I call send, it will re-do validate internally and pass on the ticket.

substrate/frame/staking-async/rc-client/src/lib.rs

- Deprecated `asset-hub-next`, replaced by `staking-async-parachain` and `staking-async-rc` in paritytech/polkadot-sdk#8422 - Add support for statemint, statemine, westmint AH chains, without dropping the polkadot / kusama / westend RC variants until we deprecate the legacy `monitor` path and rely only on EPMB For the time being, static miner's config for StakingAsync is a copy-paste of Westend one but will evolve independently. As a separate topic (see #994), a partial / complete removal of the static configuration per chain will be tackled.

…staking-async-xcm-weight

paritytech-workflow-stopper · 2025-05-30T14:24:37Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15348836777
Failed job name: fmt

* static config: Add support for AH and staking-async chains - Deprecated `asset-hub-next`, replaced by `staking-async-parachain` and `staking-async-rc` in paritytech/polkadot-sdk#8422 - Add support for statemint, statemine, westmint AH chains, without dropping the polkadot / kusama / westend RC variants until we deprecate the legacy `monitor` path and rely only on EPMB For the time being, static miner's config for StakingAsync is a copy-paste of Westend one but will evolve independently. As a separate topic (see #994), a partial / complete removal of the static configuration per chain will be tackled. * Remove staking-async support from legacy This change removes staking-async runtime support from the legacy monitor code path, replacing it with appropriate error messages for unsupported cases.

* master: omni-node: fix `benchmark pallet` to work with `--runtime` (#8594) Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731) Implement detailed logging for XCM failures (#8724) [pallet-revive] contract's nonce starts at 1 (#8734) sync/fix: Clear gap sync on known imported blocks (#8445) [PoP] Add personhood tracking pallets (#8164) client/net: Use litep2p as the default network backend (#8461) Unflake `returns_status_for_pruned_blocks` (#8709) [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704) Remove all XCM dependencies from `pallet-revive` (#8584) Docker master image tag fix (#8711) Record ed as part of the storage deposit (#8718) [pallet-revive] update dry-run logic (#8662) feat: add collator peer ID to ParachainInherentData (#8708) Nest errors in pallet-xcm (#7730) pallet-assets ERC20 precompile (#8554) Broker: Introduce min price + adjust renewals to lower market. (#8630) [AHM] Staking async fixes for XCM and election planning (#8422) Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)

This PR brings a few small fixes related to the XCM messages of staking-async, among other small fixes: * [x] Allows `xcm::validate` to check the message size, and we actually now act upon it in the `staking-async-rc/parachain-runtime`s. The code is a bit duplicate now, and there is a TOOD about how to better refactor it later. * [x] Part of this work is backported separately as #8409 * [x] It brings a default `EraElectionPlannerOf` which should be the right tool to use to ensure elections always happen in time, with an educated guess based on `ElectionProvider::duration` rather than a random number. * [x] It adds a few unit tests about the above * [x] It silences some logs that were needlessly `INFO`, and makes the printing of some types a bit more CLI friendly. * [x] Fix the issue with duplicate voters in solution type: see #8585 * [x] Move `PagedRawSolution` to be unbounded, and therefore decode-able without PoV * [x] Undo a rename from `ClaimedRewards` to `ErasClaimedRewards` * [ ] Needs fixing in westend --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Paolo La Camera <paolo@parity.io>

#8585) Backports a part of #8422 to master so it can be included in ongoing releases sooner. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>

This PR brings a few small fixes related to the XCM messages of staking-async, among other small fixes: * [x] Allows `xcm::validate` to check the message size, and we actually now act upon it in the `staking-async-rc/parachain-runtime`s. The code is a bit duplicate now, and there is a TOOD about how to better refactor it later. * [x] Part of this work is backported separately as #8409 * [x] It brings a default `EraElectionPlannerOf` which should be the right tool to use to ensure elections always happen in time, with an educated guess based on `ElectionProvider::duration` rather than a random number. * [x] It adds a few unit tests about the above * [x] It silences some logs that were needlessly `INFO`, and makes the printing of some types a bit more CLI friendly. * [x] Fix the issue with duplicate voters in solution type: see #8585 * [x] Move `PagedRawSolution` to be unbounded, and therefore decode-able without PoV * [x] Undo a rename from `ClaimedRewards` to `ErasClaimedRewards` * [ ] Needs fixing in westend --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Paolo La Camera <paolo@parity.io>

allow and test staking-async xcm messages to be splitted

82f9339

kianenigma added the T2-pallets This PR/Issue is related to a particular pallet. label May 5, 2025

kianenigma requested a review from a team as a code owner May 5, 2025 09:05

acatangiu reviewed May 5, 2025

View reviewed changes

kianenigma and others added 3 commits May 5, 2025 11:57

Update substrate/frame/staking-async/runtimes/parachain/src/staking.rs

2d0f7be

Co-authored-by: Adrian Catangiu <adrian@parity.io>

Update substrate/frame/staking-async/runtimes/parachain/src/staking.rs

6da3b99

Co-authored-by: Adrian Catangiu <adrian@parity.io>

Apply suggestions from code review

03ace80

Co-authored-by: Adrian Catangiu <adrian@parity.io>

acatangiu approved these changes May 5, 2025

View reviewed changes

kianenigma added 2 commits May 5, 2025 14:03

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

35b8e05

…staking-async-xcm-weight

fmt

ee701f5

github-actions bot and others added 2 commits May 5, 2025 13:06

Update from github-actions[bot] running command 'prdoc --bump minor'

669ef3e

small fixes, waiting for 8409 to be merged

88096fd

kianenigma mentioned this pull request May 7, 2025

[AHM]: Final Staking Configs for Westend Migration #8455

Closed

5 tasks

kianenigma added 4 commits May 14, 2025 23:18

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

cca3008

…staking-async-xcm-weight

make paged solution unbounded -- but not tested yet with ZN, it shoul…

b82ea6c

…d now allow page count to be in storage

ErasClaimedRewards -> ClaimedRewards

9c1c6f4

fix epmb solution duplicate issue + add remote mining apparatus to epm

d5de81c

kianenigma mentioned this pull request May 20, 2025

fix epmb solution duplicate issue + add remote mining apparatus to epm #8585

Merged

kianenigma added 4 commits May 21, 2025 00:40

Master.into()

1e98f35

feature-gate it

641015f

fix test ordering

1c24d17

fmt

10a0869

tdimitrov reviewed May 21, 2025

View reviewed changes

substrate/frame/staking-async/runtimes/parachain/src/staking.rs Outdated Show resolved Hide resolved

kianenigma added 2 commits May 22, 2025 11:52

refactor XCM stuff

d70ba72

Master.into()

6a682fc

kianenigma commented May 22, 2025

View reviewed changes

add Justfile

971b9e9

kianenigma added 5 commits May 29, 2025 10:32

small improvement in chunk_size

35683a9

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

d54db21

…staking-async-xcm-weight

fmt

d2b84df

Merge branch 'kiz-staking-async-xcm-weight' of github.com:paritytech/…

3451ade

…polkadot-sdk into kiz-staking-async-xcm-weight

zepter

c3d0a8f

bkontur reviewed May 29, 2025

View reviewed changes

kianenigma and others added 3 commits May 29, 2025 12:10

fix prdoc

3d2e865

taplo

9ab18e7

staking-async: rename relay and parachain version runtimes

c161aeb

sigurpol approved these changes May 30, 2025

View reviewed changes

substrate/frame/staking-async/rc-client/src/lib.rs Show resolved Hide resolved

substrate/frame/staking-async/rc-client/src/lib.rs Show resolved Hide resolved

sigurpol mentioned this pull request May 30, 2025

static config: Add support for AH and staking-async chains paritytech/polkadot-staking-miner#1064

Merged

kianenigma added 4 commits May 30, 2025 15:17

rename SessionsPerEra back

caf5024

prdoc

0c266f6

Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…

83586c9

…staking-async-xcm-weight

taplo

0ea8d91

fmt

e9ed85d

kianenigma enabled auto-merge May 30, 2025 14:47

kianenigma added this pull request to the merge queue May 30, 2025

Merged via the queue into master with commit 7bb570d May 30, 2025
268 of 272 checks passed

kianenigma deleted the kiz-staking-async-xcm-weight branch May 30, 2025 16:32

kianenigma mentioned this pull request Jun 5, 2025

[☂️ AHM-Kusama] Tracking Issue for Staking #8764

Closed

8 tasks

github-actions bot mentioned this pull request Oct 24, 2025

Update polkadot-sdk from stable2503 to stable2506 moondance-labs/tanssi#1340

Closed

Conversation

kianenigma commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented May 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma commented May 5, 2025

Uh oh!

Uh oh!

kianenigma May 22, 2025

Choose a reason for hiding this comment

Uh oh!

bkontur May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bkontur May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bkontur May 29, 2025

Choose a reason for hiding this comment

Uh oh!

kianenigma May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bkontur May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kianenigma May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paritytech-workflow-stopper bot commented May 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kianenigma commented May 5, 2025 •

edited

Loading

bkontur May 29, 2025 •

edited

Loading

kianenigma May 29, 2025 •

edited

Loading