Skip to content

[stable2412] Backport #8585#8601

Merged
EgorPopelyaev merged 6 commits intostable2412from
backport-8585-to-stable2412
May 21, 2025
Merged

[stable2412] Backport #8585#8601
EgorPopelyaev merged 6 commits intostable2412from
backport-8585-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #8585 into stable2412 from kianenigma.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8585-to-stable2412
git worktree add --checkout .worktree/backport-8585-to-stable2412 backport-8585-to-stable2412
cd .worktree/backport-8585-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 5d71d474ab78dacc37f89698a71baa45b41d0302
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 21, 2025
@github-actions github-actions bot requested a review from kianenigma May 21, 2025 16:05
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@kianenigma kianenigma marked this pull request as ready for review May 21, 2025 16:25
- name: frame-election-provider-support
bump: patch
- name: sp-npos-elections
bump: major
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not re-use another error?
Either way it should be minor, otherwise we will bump crate versions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we can, lemme fix it in both

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope sorry all other errors are very unrelated. Let's just do minor

Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(preemptively approving)

@EgorPopelyaev EgorPopelyaev merged commit 9e64443 into stable2412 May 21, 2025
175 of 194 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8585-to-stable2412 branch May 21, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants