Skip to content

Bridges: Fix - Improve try-state for pallet-xcm-bridge-hub#8615

Merged
rosarp merged 10 commits intoparitytech:masterfrom
rosarp:rs-bridges-try-state-fixes
May 26, 2025
Merged

Bridges: Fix - Improve try-state for pallet-xcm-bridge-hub#8615
rosarp merged 10 commits intoparitytech:masterfrom
rosarp:rs-bridges-try-state-fixes

Conversation

@rosarp
Copy link
Copy Markdown
Member

@rosarp rosarp commented May 22, 2025

Fixing #8215 based on #8185: Improve try-state for pallet-xcm-bridge-hub

It removes try_as and uses try_into implementation instead.

@rosarp rosarp added R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges. labels May 22, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 22, 2025 13:11
@rosarp rosarp requested a review from bkontur May 22, 2025 13:13
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 22, 2025

/cmd fmt

@rosarp
Copy link
Copy Markdown
Member Author

rosarp commented May 22, 2025

@bkontur Do we need to backport these too?

@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 22, 2025 19:59
@bkontur bkontur removed the R0-no-crate-publish-required The change does not require any crates to be re-published. label May 22, 2025
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 22, 2025

@bkontur Do we need to backport these too?

@rosarp yes, please add prdoc first, I removed R0-silent

@rosarp
Copy link
Copy Markdown
Member Author

rosarp commented May 23, 2025

/cmd prdoc --audience runtime_dev --bump patch

@rosarp rosarp added A4-backport-stable2412 A4-backport-stable2503 Pull request must be backported to the stable2503 release branch labels May 23, 2025
@rosarp rosarp enabled auto-merge May 23, 2025 11:03
@rosarp rosarp added this pull request to the merge queue May 26, 2025
Merged via the queue into paritytech:master with commit c2174ff May 26, 2025
184 checks passed
@rosarp rosarp deleted the rs-bridges-try-state-fixes branch May 26, 2025 13:08
paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 26, 2025
Fixing #8215 based on
#8185: Improve
try-state for pallet-xcm-bridge-hub

It removes try_as and uses try_into implementation instead.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c2174ff)
@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2412:

@paritytech-release-backport-bot
Copy link
Copy Markdown

Successfully created backport PR for stable2503:

paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 26, 2025
Fixing #8215 based on
#8185: Improve
try-state for pallet-xcm-bridge-hub

It removes try_as and uses try_into implementation instead.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c2174ff)
bkontur added a commit that referenced this pull request May 27, 2025
Backport #8615 into `stable2503` from rosarp.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Rohit Sarpotdar <rohit.sarpotdar@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bkontur added a commit that referenced this pull request May 27, 2025
Backport #8615 into `stable2412` from rosarp.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Rohit Sarpotdar <rohit.sarpotdar@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ordian added a commit that referenced this pull request May 27, 2025
* master: (99 commits)
  Snowbridge: Remove asset location check for compatibility (#8473)
  add poke_deposit extrinsic to pallet-bounties (#8382)
  litep2p/peerset: Reject non-reserved peers in the reserved-only mode (#8650)
  Charge deposit based on key length (#8648)
  [pallet-revive] make subscription task panic on error (#8587)
  tx/metrics: Add metrics for the RPC v2 `transactionWatch_v1_submitAndWatch` (#8345)
  Bridges: Fix - Improve try-state for pallet-xcm-bridge-hub (#8615)
  Introduce CreateBare, deprecated CreateInherent (#7597)
  Use hashbrown hashmap/hashset in validation context (#8606)
  ci: rm gitlab config (#8622)
  🔪 flaky and Zombienet tests (#8600)
  cumulus: adjust unincluded segment size metric buckets (#8617)
  Benchmark storage access on block validation (#8069)
  Revert 7934 es/remove tj changes (#8611)
  collator-protocol: add more collation observability (#8230)
  `fatxpool`: add fallback for ready at light (#8533)
  txpool: fix tx removal from unlocks set (#8500)
  XCMP weight metering: account for the MQ page position (#8344)
  fix epmb solution duplicate issue + add remote mining apparatus to epm (#8585)
  Fix generated address returned by Substrate RPC runtime call (#8504)
  ...
pgherveou pushed a commit that referenced this pull request Jun 11, 2025
Fixing #8215 based on
#8185: Improve
try-state for pallet-xcm-bridge-hub

It removes try_as and uses try_into implementation instead.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
Fixing #8215 based on
#8185: Improve
try-state for pallet-xcm-bridge-hub

It removes try_as and uses try_into implementation instead.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch T15-bridges This PR/Issue is related to bridges.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants