Skip to content

[pallet-revive] update dry-run logic#8662

Merged
pgherveou merged 26 commits intomasterfrom
pg/revert-nonce-bump
Jun 2, 2025
Merged

[pallet-revive] update dry-run logic#8662
pgherveou merged 26 commits intomasterfrom
pg/revert-nonce-bump

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented May 26, 2025

@pgherveou pgherveou changed the base branch from master to pg/impl-runtime-macro May 26, 2025 22:05
@pgherveou pgherveou force-pushed the pg/revert-nonce-bump branch 4 times, most recently from d4ff475 to d0cbd23 Compare May 26, 2025 22:12
@pgherveou pgherveou force-pushed the pg/revert-nonce-bump branch from d0cbd23 to 20e3e3c Compare May 26, 2025 22:14
@pgherveou pgherveou marked this pull request as ready for review May 26, 2025 22:15
@pgherveou
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump patch

@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label May 26, 2025
@pgherveou
Copy link
Copy Markdown
Contributor Author

@athei @castillax

Got some second though on the previous PR (#8504)
I think it's best to not have different logic for executing & dry-running transaction, and instead as @gui1117 suggested (you were right, should have thought about your comment more carefully) we should have some setup code that simulate what the transaction extension do pre-dispatch (for now I am just bumping the nonce)

I realized it was important while working on the prestate tracer where we also want to collect the nonce change when we trace a call.

Base automatically changed from pg/impl-runtime-macro to master May 27, 2025 11:41
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15389909647
Failed job name: cargo-clippy

@pgherveou pgherveou enabled auto-merge June 2, 2025 11:08
@pgherveou pgherveou added this pull request to the merge queue Jun 2, 2025
Merged via the queue into master with commit fb41dde Jun 2, 2025
256 of 259 checks passed
@pgherveou pgherveou deleted the pg/revert-nonce-bump branch June 2, 2025 12:43
ordian added a commit that referenced this pull request Jun 4, 2025
* master:
  omni-node: fix `benchmark pallet` to work with `--runtime` (#8594)
  Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731)
  Implement detailed logging for XCM failures (#8724)
  [pallet-revive] contract's nonce starts at 1 (#8734)
  sync/fix: Clear gap sync on known imported blocks (#8445)
  [PoP] Add personhood tracking pallets (#8164)
  client/net: Use litep2p as the default network backend (#8461)
  Unflake `returns_status_for_pruned_blocks` (#8709)
  [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704)
  Remove all XCM dependencies from `pallet-revive` (#8584)
  Docker master image tag fix (#8711)
  Record ed as part of the storage deposit (#8718)
  [pallet-revive] update dry-run logic (#8662)
  feat: add collator peer ID to ParachainInherentData (#8708)
  Nest errors in pallet-xcm (#7730)
  pallet-assets ERC20 precompile (#8554)
  Broker: Introduce min price + adjust renewals to lower market. (#8630)
  [AHM] Staking async fixes for XCM and election planning (#8422)
  Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)
pgherveou added a commit that referenced this pull request Jun 11, 2025
- Revert #8504
- Add a `prepare_dry_run` that run before bare_call / bare_instantiate

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
- Revert #8504
- Add a `prepare_dry_run` that run before bare_call / bare_instantiate

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants