static config: Add support for AH and staking-async chains#1064
Merged
static config: Add support for AH and staking-async chains#1064
Conversation
- Deprecated `asset-hub-next`, replaced by `staking-async-parachain` and `staking-async-rc` in paritytech/polkadot-sdk#8422 - Add support for statemint, statemine, westmint AH chains, without dropping the polkadot / kusama / westend RC variants until we deprecate the legacy `monitor` path and rely only on EPMB For the time being, static miner's config for StakingAsync is a copy-paste of Westend one but will evolve independently. As a separate topic (see #994), a partial / complete removal of the static configuration per chain will be tackled.
Contributor
Author
|
@kianenigma , PTAL when you have time. This ideally needs to get merged at the same time of your epic PR due to these changes |
kianenigma
reviewed
Jun 2, 2025
kianenigma
reviewed
Jun 2, 2025
kianenigma
approved these changes
Jun 2, 2025
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
I think we can remove a few code paths and just make them be panic!() or unimplemented!("legacy miner does not support multi-block") or the other way unimplemented!("multi-block mining is not supported on relay chains") etc.
This change removes staking-async runtime support from the legacy monitor code path, replacing it with appropriate error messages for unsupported cases.
Contributor
Author
Remove staking-async support from legacy (with related UT as extra bonus 😄 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asset-hub-nextas runtime version forstaking-async, replaced bystaking-async-parachainandstaking-async-rc(see here)statemint,statemine,westmintAH chains, without dropping thepolkadot/kusama/westendRC runtime version variants until we deprecate the legacymonitorpath and rely only on EPMBstaking-asyncsupport from the legacy pathFor the time being, static miner's config for
StakingAsyncis a copy-paste ofWestendone but will evolve independently.As a separate topic (see #994), a partial / complete removal of the static configuration per chain will be tackled.
Close #1065