Conversation
svyatonik
approved these changes
May 16, 2023
bkontur
commented
May 16, 2023
| pub votes_ancestries: Vec<Header>, | ||
| } | ||
|
|
||
| // TODO: remove and use `RuntimeDebug` (https://github.com/paritytech/parity-bridges-common/issues/2136) |
Collaborator
Author
There was a problem hiding this comment.
@svyatonik @serban300
I have no idea why this does not work in Cumulus for bridge-hub-rococo-runtime,
probably some Cargo.lock/Cargo.toml + features propagation problem or I missed something.
Tried severel things but nothing worked.
cargo check --all --features try-runtime works for bridges repo and all rialto/millau runtimes, but does not work for Cumulus when RuntimeDebug is used here, strange.
Contributor
There was a problem hiding this comment.
We'll take a look, for sure. Thanks for filing an issue
4 tasks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Nits (merge before separatelly) * Small cosmetics for Rococo/Wococo bridge local run * Squashed 'bridges/' changes from 04b3dda..5fc377a 5fc377a Support for kusama-polkadot relaying (#2128) 01f4b7f Fix clippy warnings (#2127) 696ff1c BHK/P alignments (#2115) 2a66aa3 Small fixes (#2126) 7810f1a Cosmetics (#2124) daf250f Remove some `expect()` statements (#2123) 1c5fba8 temporarily remove balance guard (#2121) 3d0e547 Propagate message receival confirmation errors (#2116) 1c33143 Propagate message verification errors (#2114) b075b00 Bump time from 0.3.20 to 0.3.21 51a3a51 Bump serde from 1.0.160 to 1.0.162 da88d04 Bump clap from 4.2.5 to 4.2.7 cdca322 Bump sysinfo from 0.28.4 to 0.29.0 git-subtree-dir: bridges git-subtree-split: 5fc377a * Fix * Allow to change storage constants (DeliveryReward, RequiredStakeForStakeAndSlash) + tests * Clippy * New SA for RO/WO * Squashed 'bridges/' changes from 5fc377a..0f6091d 0f6091d Bump polkadot/substrate (#2134) 9233f0a Bump tokio from 1.28.0 to 1.28.1 a29c1ca Bump serde from 1.0.162 to 1.0.163 git-subtree-dir: bridges git-subtree-split: 0f6091d
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Bump polkadot/substrate * Fix millau network service * Fix polkadot_node_core_pvf_worker * Fix sc-network * Fix parachain rpc stuff * Check `integrity-test` for `bridge-runtime-common` * Backport fix from cumulus https://github.com/paritytech/cumulus/pull/2585/files#diff-5a942d80670b5ef31bb18b5acacab93ff30512d7cd21c19d7da364f76f6bb5c3 because of https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2842938 * TODO * Bump cumulus
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Bump polkadot/substrate * Fix millau network service * Fix polkadot_node_core_pvf_worker * Fix sc-network * Fix parachain rpc stuff * Check `integrity-test` for `bridge-runtime-common` * Backport fix from cumulus https://github.com/paritytech/cumulus/pull/2585/files#diff-5a942d80670b5ef31bb18b5acacab93ff30512d7cd21c19d7da364f76f6bb5c3 because of https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2842938 * TODO * Bump cumulus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.