Skip to content

Ws-port argument has been repalced with rpc-port#2140

Merged
svyatonik merged 5 commits intomasterfrom
fix-nodes-startup
May 18, 2023
Merged

Ws-port argument has been repalced with rpc-port#2140
svyatonik merged 5 commits intomasterfrom
fix-nodes-startup

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

@svyatonik svyatonik commented May 17, 2023

Follow up for #2134 and #2138

This PR:

  • RialtoParachain collator nodes are not starting because ws-port argument has been removed;
  • RialtoParachain <> Millau bridge is not working
    • RialtoParachain collators have zero parachain peers and zero relay chain peers
    • "Could not send block production result to proposer!" in collator logs

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label May 17, 2023
@bkontur
Copy link
Copy Markdown
Collaborator

bkontur commented May 17, 2023

uff, sorry for that, I knew that I forgot something, to check dockers yesterday :(

@svyatonik
Copy link
Copy Markdown
Contributor Author

uff, sorry for that, I knew that I forgot something, to check dockers yesterday :(

It's fine :) Rialto<>Millau exist to be broken and detect such changes

slot_duration,
// We got around 500ms for proposing
block_proposal_slot_portion: SlotProportion::new(1f32 / 24f32),
// We got around 1000ms for proposing
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has caused problems for me - parachain was unable to produce any blocks within 500ms, so I've increased it to 1s.

entrypoint: >
/home/user/rialto-parachain-collator
--alice
--node-key=80cf382988364291a7968ae7825c01f68c50d679796a8983237d07fe0ccf363b
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some recent changes in networking && I guess our parachain nodes can't connect to each other because of that => I've added stuff similar to what we have in Rialto and Millau

@svyatonik svyatonik marked this pull request as ready for review May 18, 2023 13:53
@svyatonik svyatonik merged commit 334df22 into master May 18, 2023
@svyatonik svyatonik deleted the fix-nodes-startup branch May 18, 2023 14:16
@svyatonik svyatonik mentioned this pull request May 24, 2023
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
* Skip verification on state import

* Actually use existing variables

* Merge checks
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
* Squashed 'bridges/' changes from 0f6091d..c9dd8b9

c9dd8b9 expose test utilities to be used in BH paras (#2142)
334df22 Ws-port argument has been repalced with rpc-port (#2140)
106173c fix nodes startup (#2138)

git-subtree-dir: bridges
git-subtree-split: c9dd8b9

* tmp
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* ws-port argument has been repalced with rpc-port

* fixed paras pallet weight and expose unsigned validation

* add bootnodes to RialtoParachain collators

* another bump + increase block proposal time

* revert RUST_LOG=trace for test network nodes
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* ws-port argument has been repalced with rpc-port

* fixed paras pallet weight and expose unsigned validation

* add bootnodes to RialtoParachain collators

* another bump + increase block proposal time

* revert RUST_LOG=trace for test network nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-chores Something that has to be done, as part of regular maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants