Remove some expect() statements#2123
Merged
serban300 merged 4 commits intoparitytech:masterfrom May 9, 2023
Merged
Conversation
Prevent unexpected failures.
svyatonik
approved these changes
May 9, 2023
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.60 to 0.1.63. - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](dtolnay/async-trait@0.1.60...0.1.63) --- updated-dependencies: - dependency-name: async-trait dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Nits (merge before separatelly) * Small cosmetics for Rococo/Wococo bridge local run * Squashed 'bridges/' changes from 04b3dda..5fc377a 5fc377a Support for kusama-polkadot relaying (#2128) 01f4b7f Fix clippy warnings (#2127) 696ff1c BHK/P alignments (#2115) 2a66aa3 Small fixes (#2126) 7810f1a Cosmetics (#2124) daf250f Remove some `expect()` statements (#2123) 1c5fba8 temporarily remove balance guard (#2121) 3d0e547 Propagate message receival confirmation errors (#2116) 1c33143 Propagate message verification errors (#2114) b075b00 Bump time from 0.3.20 to 0.3.21 51a3a51 Bump serde from 1.0.160 to 1.0.162 da88d04 Bump clap from 4.2.5 to 4.2.7 cdca322 Bump sysinfo from 0.28.4 to 0.29.0 git-subtree-dir: bridges git-subtree-split: 5fc377a * Fix * Allow to change storage constants (DeliveryReward, RequiredStakeForStakeAndSlash) + tests * Clippy * New SA for RO/WO * Squashed 'bridges/' changes from 5fc377a..0f6091d 0f6091d Bump polkadot/substrate (#2134) 9233f0a Bump tokio from 1.28.0 to 1.28.1 a29c1ca Bump serde from 1.0.162 to 1.0.163 git-subtree-dir: bridges git-subtree-split: 0f6091d
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Return error on save_message() Prevent unexpected failures. * Remove RefCell * Fix spellcheck * CI fixes
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Return error on save_message() Prevent unexpected failures. * Remove RefCell * Fix spellcheck * CI fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2433
Remove some
expect()statements in order to avoid unpredictable failures.