fix: spacing for align bottom vertical layouts#909
Merged
Nottinghster merged 1 commit intomainfrom Oct 7, 2024
Merged
Conversation
Nottinghster
approved these changes
Oct 7, 2024
jordanhoare
added a commit
to tibia-oce/otclient
that referenced
this pull request
Oct 11, 2024
* perf: Drawpool 3.1 more stability in FPS * setting m_effectAlpha, m_missileAlpha to 1.f * fix: display density on mapview * feat: hud scale * fix: Interface Anchors (opentibiabr#862) * feat: support directx * improve: use egl v3 * small change in gc * fix: memory leak in controller * improve: organization of the project structure * add new config to draw covered things There are projects where this system doesn't work very well, so if your project is one of those, just set it to true to fix the tiles that aren't being drawn. * feat: update background image and startup sound to use 13.40 cip files. Adjustments in options buttons order and logout button icon. (opentibiabr#865) * update UIGraph (need test) * fix shader warning * fix: console error due to shaders * draw-covered-things to false Note: Setting false will not draw objects that the client understands are covered. If for some reason a tile is not being drawn because your game is custom, set this property to true and this issue will be resolved. * baseline updated (update your vcpkg) git pull * Revert "baseline updated (update your vcpkg)" This reverts commit 8dda995. * fix: opentibiabr#867 * feat: extractTexture in framebuffer, Arch SS2 by default and cleanup * fix: inverted texture in extractTexture * html: support tag img * perf: reducing locking, thus increasing performance a little. * fix draw shader * prevent crash in static text * improve: add lua call protection * perf: improve propagateOnMouseMove * fix: bot item ondrop and analyzer loot channel (opentibiabr#887) * fix: outfit size , prevent ERROR: invalid thing (opentibiabr#884) Co-authored-by: Rodrigo Paixão <[email protected]> * improve: HTTP login error handling to display login.php error messages (opentibiabr#886) * fix: compilation error on some pcs * feat: full cyclopedia module (opentibiabr#868) * fix: game_store bugs. fix: opentibiabr#873 (opentibiabr#874) * feat: Minimap GM teleport ( ctrl +shift + click on minimap) (opentibiabr#885) Co-authored-by: Luan Luciano <[email protected]> * support "Mage" vocation (opentibiabr#882) several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED. Without this fix, on those servers, vBot would constantly error out with Error: (...) concatenat voc: a nil value * fix (opentibiabr#900) * improve parseOpenContainer and fix error with decoration kit (opentibiabr#890) * fix: optional display rarity colors in items . feature GameColorizedLootValue 12.00 (opentibiabr#896) * fix: crash getItems (opentibiabr#892) * looting blacklist (opentibiabr#881) When "loot every item" is off, it will loot everything in the loot list. When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on. * Fix black and red squares behaviors (opentibiabr#902) * Fix squares: - Set black squares color to 1 instead of 0 so it's not treated as alpha - Fix creaturesMark logic so red squares don't disappear when attacking and black squares show when attacked * feat: display tier UI (GameThingUpgradeClassification) (opentibiabr#895) * feat: Vips Groups | fix issue: opentibiabr#730 (opentibiabr#908) * fix: spacing for align bottom vertical layouts (opentibiabr#909) * Fix: opentibiabr#901 --------- Co-authored-by: Renato Machado <[email protected]> Co-authored-by: SkullzOTS <[email protected]> Co-authored-by: Luan Luciano <[email protected]> Co-authored-by: Felipe Muniz <[email protected]> Co-authored-by: Rodrigo Paixão <[email protected]> Co-authored-by: kokekanon <[email protected]> Co-authored-by: divinity76 <[email protected]> Co-authored-by: divinity76 <[email protected]> Co-authored-by: OT Archive <[email protected]> Co-authored-by: Marcin Jałocha <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spacing is wrongly added for align-bottom vertical layouts
Behavior
Actual
It works in reverse, deduces the spacing instead of adding
Expected
Should add spacing between elements
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist