Vip list group

[Riverlance]

Priority

Missing Content

Area

• Data
• Source
• Docker
• Other

What is missing?

The feature Otc::GameVipGroups is not implemented, as shown below:

Code of Conduct

• I agree to follow this project's Code of Conduct

[luanluciano93]

Can you explain better? the feature is automatically activated in versions 12+
https://github.com/mehah/otclient/blob/11cc1536ebd9b39b4bb77cfb7c544e5d28f945b3/modules/game_features/features.lua#L184

[Riverlance]

Can you explain better? the feature is automatically activated in versions 12+

https://github.com/mehah/otclient/blob/11cc1536ebd9b39b4bb77cfb7c544e5d28f945b3/modules/game_features/features.lua#L184

Sure.
It is activated indeed, although it is not implemented.

When you write lines like:

msg->getU8(); // Group ID
msg->getString(); // Group name
msg->getU8(); // Can edit group? (bool)

You are receiving data from server about vip groups, but doing nothing with them.
You need to assign them to variables, then use into a function that should pass through a Lua callback which will implement the visual of groups on Vip List mini window.
See id, name, status, desc, iconId, notifyLogin used on g_game.processVipAdd to see how it should be done.

---

1. The correct would be something like myVariable = msg->getU8();, not just msg->getU8(); without signing it to a variable nor using it.
2. And then using myVariable in g_game.processVipAdd (in case of ProtocolGame::parseVipAdd) or in g_game.processVipStateChange (in case of ProtocolGame::parseVipLogout).
3. Finally, it should be implemented on Lua in g_game.onAddVip (in case of g_game.processVipAdd) or in g_game.onVipStateChange (in case of g_game.processVipStateChange).
4. Once you have the data about groups on Vip List mini window Lua module, you can use it to implement the visual in this mini window.

[github-actions]

This issue is stale because it has been open 120 days with no activity.

[kokekanon]

I use 8.6 I will never use that function. but Well I tried xd .
only "addvip" and "refreshgruop" function lua are missing.
I'm not good with MiniWindowContents

I wont continue
if anyone wants to see the changes or continue:
see this
https://github.com/kokekanon/otclient.readme/commit/582d7909c9ec7aafbdfeca243664a997172b06d7
kokekanon@582d790

modules.game_viplist.toggleViewMode()

groups.groupsName = { 
    [1] = { 
        [1] = 1, -- ID group
        [2] = "Enemies",  -- group name
        [3] = false --idk
    },
    [2] = { 
        [1] = 2,
        [2] = "Friends",
        [3] = false
    },
    [3] = { 
        [1] = 3,
        [2] = "Trading Partner",
        [3] = false
    },
    [4] = { 
        [1] = 4,
        [2] = "weas",
        [3] = true
    },
    [5] = { 
        [1] = 5,
        [2] = "nvbnvbn",
        [3] = true
    },
    [6] = { 
        [1] = 6,
        [2] = "1",
        [3] = true
    },
    [7] = { 
        [1] = 7,
        [2] = "pocoyo",
        [3] = true
    }
}

function onAddVip(id, name, state, description, iconId, notify, groupID)
    print('onAddVip', id, name, groupID)
    onAddVip    6    GOD    {1,2}
    
    onAddVip    4    Paladin Sample {2}
end