fix: crash getItems

[luanluciano93]

[bateunatrave]

Now the trade window is appearing, but when the other player's item appears, the crash occurs.

[luanluciano93]

Now the trade window is appearing, but when the other player's item appears, the crash occurs.

Can you use the deputy to see where the crash is occurring, like the PR image?

[kokekanon]

test in 13.40

in my test there is no crash, but when I accept the trade

i don't know if the error is in canary or otc. but for some reason
server sent 0x89 to client.

ERROR: ProtocolGame parse message exception (357 bytes, 348 unread, last opcode is 0x89 (137), prev opcode is 0xffffffff (-1)): unhandled opcode 137
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1340)

src/client/protocolcodes.h
GameServerCloseForgeWindow = 137,


src/client/protocolgame.h
void parseCloseForgeWindow(const InputMessagePtr& msg);


src/client/protocolgameparse.cpp
....
                case Proto::GameServerCloseForgeWindow:
                    parseCloseForgeWindow(msg);
                    break;
                    
...
                    
void ProtocolGame::parseCloseForgeWindow(const InputMessagePtr& msg)
{
    g_lua.callGlobalField("g_game", "onCloseForgeWindow"); // TODO: implement 
}

in 8.6 this error does not occur