Skip to content

[OSDEV-1589] [FE] Layout issue on "contribute" page#513

Merged
roman-stolar merged 8 commits intomainfrom
OSDEV-1589-layout-issue-contribute-page
Feb 14, 2025
Merged

[OSDEV-1589] [FE] Layout issue on "contribute" page#513
roman-stolar merged 8 commits intomainfrom
OSDEV-1589-layout-issue-contribute-page

Conversation

@roman-stolar
Copy link
Contributor

@roman-stolar roman-stolar commented Feb 13, 2025 •
edited by atlassian bot
Loading

OSDEV-1589 [FE] Layout issue on "contribute" page

@roman-stolar roman-stolar self-assigned this Feb 13, 2025
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:18 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 13, 2025 13:20 — with GitHub Actions Inactive
VadimKovalenkoSNF
VadimKovalenkoSNF previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: make a spreadsheet as bold text. Besides that - approved.
image

mazursasha1990
mazursasha1990 suggested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the provided styles in the comments, because currently, the cards are not proportional.
Screenshot from 2025-02-14 10-06-58

@roman-stolar
Copy link
Contributor Author

roman-stolar commented Feb 14, 2025

Nitpick: make a spreadsheet as bold text. Besides that - approved. image

The text style parameter is same as in design spec.

@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment February 14, 2025 10:29 — with GitHub Actions Inactive
mazursasha1990
mazursasha1990 previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

VadimKovalenkoSNF
VadimKovalenkoSNF approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

mazursasha1990
mazursasha1990 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Feb 14, 2025
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 28, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@VadimKovalenkoSNF VadimKovalenkoSNF VadimKovalenkoSNF approved these changes

@vladsha-dev vladsha-dev Awaiting requested review from vladsha-dev

+1 more reviewer

@mazursasha1990 mazursasha1990 mazursasha1990 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@roman-stolar roman-stolar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roman-stolar @mazursasha1990 @VadimKovalenkoSNF