Skip to content

[OSDEV-1867] SLC. Update Messy Data link to data cleaning service splash page#561

Merged
roman-stolar merged 2 commits intomainfrom
OSDEV-1867-update-messy-data-link
Mar 17, 2025
Merged

[OSDEV-1867] SLC. Update Messy Data link to data cleaning service splash page#561
roman-stolar merged 2 commits intomainfrom
OSDEV-1867-update-messy-data-link

Conversation

@roman-stolar
Copy link
Contributor

@roman-stolar roman-stolar commented Mar 17, 2025

OSDEV-1867 SLC. Update Messy Data link to data cleaning service splash page

  • Updated the 'Messy Data' link on the Contribute page and List Upload page to direct users to the Data Cleaning Service splash page instead of the old Preparing Data page.

…to the Data Cleaning Service splash page instead of the old Preparing Data page.
@roman-stolar roman-stolar self-assigned this Mar 17, 2025
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar requested a review from Innavin369 March 17, 2025 09:15
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:15 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:17 — with GitHub Actions Inactive
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2025

📝 Walkthrough

Walkthrough

This pull request updates the Open Supply Hub project by modifying the navigation for the "Messy Data" link on the Contribute page. The release notes now include an entry detailing the change, and the code has been updated so that the InfoPaths.contribute constant points to the Data Cleaning Service splash page instead of the old Preparing Data page.

Changes

File(s) changed Change Summary
doc/release/RELEASE-NOTES.md, src/react/src/util/constants.jsx Updated the navigation for the "Messy Data" link on the Contribute page by adding a release note entry and changing InfoPaths.contribute from resources/preparing-data to data-cleaning-service.

Possibly related PRs

  • [OSDEV-1589] [FE] Layout issue on "contribute" page #513: The changes in the main PR, which update the 'Messy Data' link in the release notes and modify the InfoPaths object, are related to the changes in the retrieved PR that also involve the Contribute page, specifically through the context of routing and resource links.

Suggested reviewers

  • vladsha-dev
  • mazursasha1990
  • VadimKovalenkoSNF

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d271eb and 406fee9.

📒 Files selected for processing (1)
  • doc/release/RELEASE-NOTES.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • doc/release/RELEASE-NOTES.md
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: check-fe-code-cov
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-contricleaner-cov

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@barecheck
Copy link

barecheck bot commented Mar 17, 2025

React App | Jest test suite - Code coverage report

Total: 33.09%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/react/src/util/constants.jsx (1)

1328-1333: Note: Consider updating hardcoded URL reference

There's a hardcoded URL reference to the old "preparing-data" page in the list parsing error message. While not directly related to the main functionality of the "Messy Data" link, you might want to consider updating this reference for consistency, depending on whether the template is still located at the old URL or has also been moved.

-            <a
-                href="https://info.opensupplyhub.org/resources/preparing-data"
-                target="_blank"
-                rel="noreferrer"
-            >
-                using OS Hub's template
+            <a
+                href={`${InfoLink}/${InfoPaths.contribute}`}
+                target="_blank"
+                rel="noreferrer"
+            >
+                using OS Hub's template
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbb0c05 and 9d271eb.

📒 Files selected for processing (2)
  • doc/release/RELEASE-NOTES.md (1 hunks)
  • src/react/src/util/constants.jsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-fe-code-quality
  • GitHub Check: run-eslint-linter-and-prettier-formatter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-countries-cov
🔇 Additional comments (2)
doc/release/RELEASE-NOTES.md (1)

74-74: Clear Documentation of the 'Messy Data' Link Update

This release note entry for OSDEV-1867 clearly explains that the 'Messy Data' link on the Contribute page now points to the Data Cleaning Service splash page instead of the old Preparing Data page. Please verify that this change is coordinated with any corresponding updates in the frontend (e.g., in the InfoPaths.contribute constant found in src/react/src/util/constants.jsx) to ensure user navigation is consistent across the application.

src/react/src/util/constants.jsx (1)

26-26: Update completed: Path points to data cleaning service

The InfoPaths.contribute value has been successfully updated from 'resources/preparing-data' to 'data-cleaning-service', which correctly implements the PR objective of redirecting the 'Messy Data' link to the new Data Cleaning Service splash page.

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:22 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 17, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:23 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 17, 2025

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:23 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:24 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:26 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:31 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:31 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:31 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 17, 2025 09:41 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 17, 2025

Django App | Unittest test suite - Code coverage report

Total: 80.65%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar merged commit 3b5c137 into main Mar 17, 2025
21 checks passed
@roman-stolar roman-stolar deleted the OSDEV-1867-update-messy-data-link branch March 17, 2025 10:04
protsack-stephan pushed a commit that referenced this pull request Apr 12, 2025
…ash page (#561)

[OSDEV-1867](https://opensupplyhub.atlassian.net/browse/OSDEV-1867)
**SLC. Update Messy Data link to data cleaning service splash page**

- Updated the 'Messy Data' link on the `Contribute` page and `List
Upload` page to direct users to the `Data Cleaning Service splash` page
instead of the old `Preparing Data` page.

[OSDEV-1867]:
https://opensupplyhub.atlassian.net/browse/OSDEV-1867?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants