Skip to content

[OSDEV-1739] Applied state cleanup on modal unmount#517

Merged
VadimKovalenkoSNF merged 5 commits intomainfrom
OSDEV-1739-fix-prev-modal-dialog
Feb 17, 2025
Merged

[OSDEV-1739] Applied state cleanup on modal unmount#517
VadimKovalenkoSNF merged 5 commits intomainfrom
OSDEV-1739-fix-prev-modal-dialog

Conversation

@VadimKovalenkoSNF
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF commented Feb 15, 2025

Fix OSDEV-1739

Applied state cleanup on modal unmount to prevent the same dialog from appearing when clicking on a different production location.

@VadimKovalenkoSNF VadimKovalenkoSNF self-assigned this Feb 15, 2025
@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the OSDEV-1739-fix-prev-modal-dialog branch from b46e4ed to b7ca9bb Compare February 15, 2025 06:23
roman-stolar
roman-stolar previously approved these changes Feb 17, 2025
Innavin369
Innavin369 previously approved these changes Feb 17, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)

73-75: Review Modal Cleanup Note:
The release note entry for [OSDEV-1739] clearly states that state cleanup on modal unmount has been applied to prevent the same dialog from reappearing when a user clicks on a different production location. The description is concise and understandable. Consider whether adding a brief note about which modal or what state details are being reset would provide additional clarity for non-developer stakeholders. If your audience is primarily technical and familiar with this context, the current wording is sufficient.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 625dd33 and 5a913f8.

📒 Files selected for processing (1)
  • doc/release/RELEASE-NOTES.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-fe-code-quality
  • GitHub Check: run-eslint-linter-and-prettier-formatter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-countries-cov

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)

75-76: Clarify Modal State Cleanup Description

The entry for [OSDEV-1739] explains that a state cleanup on modal unmount was applied to prevent reappearance of the dialog when clicking on a different production location. While the message is clear overall, consider adding a bit more detail—such as specifying which modal or key state variables are being reset—to help consumers of the release notes better understand the nature of the change.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a913f8 and a0d6d5f.

📒 Files selected for processing (2)
  • doc/release/RELEASE-NOTES.md (1 hunks)
  • src/react/src/components/Contribute/ProductionLocationInfo.jsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/react/src/components/Contribute/ProductionLocationInfo.jsx
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-django-cov
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-countries-cov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants