[OSDEV-1739] Applied state cleanup on modal unmount#517
[OSDEV-1739] Applied state cleanup on modal unmount#517VadimKovalenkoSNF merged 5 commits intomainfrom
Conversation
b46e4ed to
b7ca9bb
Compare
625dd33
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)
73-75: Review Modal Cleanup Note:
The release note entry for [OSDEV-1739] clearly states that state cleanup on modal unmount has been applied to prevent the same dialog from reappearing when a user clicks on a different production location. The description is concise and understandable. Consider whether adding a brief note about which modal or what state details are being reset would provide additional clarity for non-developer stakeholders. If your audience is primarily technical and familiar with this context, the current wording is sufficient.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
doc/release/RELEASE-NOTES.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-fe-code-quality
- GitHub Check: run-eslint-linter-and-prettier-formatter
- GitHub Check: run-django-code-quality
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-fe-cov
- GitHub Check: get-base-branch-dd-cov
- GitHub Check: get-base-branch-django-cov
- GitHub Check: get-base-branch-contricleaner-cov
- GitHub Check: get-base-branch-countries-cov
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)
75-76: Clarify Modal State Cleanup DescriptionThe entry for [OSDEV-1739] explains that a state cleanup on modal unmount was applied to prevent reappearance of the dialog when clicking on a different production location. While the message is clear overall, consider adding a bit more detail—such as specifying which modal or key state variables are being reset—to help consumers of the release notes better understand the nature of the change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
doc/release/RELEASE-NOTES.md(1 hunks)src/react/src/components/Contribute/ProductionLocationInfo.jsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/react/src/components/Contribute/ProductionLocationInfo.jsx
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-django-code-quality
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-dd-cov
- GitHub Check: get-base-branch-django-cov
- GitHub Check: get-base-branch-contricleaner-cov
- GitHub Check: get-base-branch-countries-cov



Fix OSDEV-1739
Applied state cleanup on modal unmount to prevent the same dialog from appearing when clicking on a different production location.