[OSDEV-1787] Fix tooltip messages for claim button#540
Conversation
Innavin369
had a problem deploying
to
Quality Environment
GitHub Actions
Failure
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
React App | Jest test suite - Code coverage reportTotal: 31.6%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Innavin369
had a problem deploying
to
Quality Environment
GitHub Actions
Error
📝 WalkthroughWalkthroughThe pull request updates the release notes for the Open Supply Hub project to reflect version 1.32.0, including a new bug fix related to tooltip messages for the Claim button. It modifies the tooltip logic in Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
doc/release/RELEASE-NOTES.md (2)
15-17: Markdown Style: Remove Trailing Punctuation in "Migrations:" Heading
The heading on line 15, "#### Migrations:", ends with a colon. According to Markdown lint guidelines (MD026), trailing punctuation in headings is discouraged. Consider changing it to "#### Migrations".🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
15-15: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
34-36: Markdown Style: Remove Trailing Punctuation in "Release instructions:" Heading
Similarly, the heading on line 34, "### Release instructions:", contains a trailing colon. Please remove the colon to comply with the markdown style guidelines (MD026) (e.g., change it to "### Release instructions").🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
34-34: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
doc/release/RELEASE-NOTES.md(1 hunks)src/react/src/components/Contribute/ProductionLocationDialog.jsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/react/src/components/Contribute/ProductionLocationDialog.jsx
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md
15-15: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
34-34: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🔇 Additional comments (2)
doc/release/RELEASE-NOTES.md (2)
6-37: New Release Section for Version 1.32.0 Added
A comprehensive release section has been introduced for version 1.32.0. This section includes the Introduction, Database changes, Migrations, Schema changes, Code/API changes, Architecture/Environment changes, Bugfix, What's new, and Release instructions. It clearly documents that the tooltip messages for the Claim button have been removed (OSDEV-1787) in accordance with the new design.
Please ensure that all placeholder text (e.g., "Describe high-level database changes.") is replaced with the finalized details before release.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
15-15: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
34-34: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
27-29: Bugfix Detail Verification for Tooltip Update
The bugfix entry for [OSDEV-1787] explicitly states that the tooltip messages for the Claim button on the Contribution Record page have been removed and updated to align with the new pop-up design ("Thanks for adding data for this production location"). This description accurately reflects the PR objective.
src/react/src/components/Contribute/ProductionLocationDialog.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
doc/release/RELEASE-NOTES.md (1)
1-5: Style Note: Verify Heading FormattingPlease ensure that all headings conform to the markdown style guidelines (e.g., avoid trailing punctuation). Although no obvious issues were found, double-check that none of the headings (such as those for sections and subsections) end with a colon or any other trailing punctuation, per MD026 recommendations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
doc/release/RELEASE-NOTES.md(1 hunks)src/react/src/components/Contribute/ProductionLocationDialog.jsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/react/src/components/Contribute/ProductionLocationDialog.jsx
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
doc/release/RELEASE-NOTES.md
17-17: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: run-integration-test-code-quality
- GitHub Check: run-flake8-linter
- GitHub Check: run-fe-code-quality
- GitHub Check: run-eslint-linter-and-prettier-formatter
- GitHub Check: run-django-code-quality
- GitHub Check: run-dd-code-quality
- GitHub Check: run-countries-code-quality
- GitHub Check: run-contricleaner-code-quality
- GitHub Check: get-base-branch-fe-cov
- GitHub Check: get-base-branch-dd-cov
- GitHub Check: get-base-branch-contricleaner-cov
- GitHub Check: get-base-branch-countries-cov
- GitHub Check: get-base-branch-django-cov
🔇 Additional comments (3)
doc/release/RELEASE-NOTES.md (3)
6-8: New Release Section for Version 1.32.0 AddedA new section for "Release 1.32.0" has been introduced with an introduction that specifies the product name ("Open Supply Hub") and the release date (March 22, 2025). Please verify that all placeholder sections (Database changes, Code/API changes, and Architecture/Environment changes) are updated with the final details before release.
29-32: Bugfix Entry for Tooltip Message UpdateThe bugfix entry for [OSDEV-1787] accurately states that the tooltip messages for the Claim button have been removed for all statuses of moderation events on the Contribution Record page and now conform to the design used in the "Thanks for adding data for this production location" pop-up. This entry looks correct; please confirm that it reflects the final implementation details.
33-37: Release Instructions CheckThe release instructions list the necessary post-deployment commands (
migrateandreindex_database). Ensure these commands are indeed sufficient for the deployment of release 1.32.0. If any additional steps are required (especially related to other infrastructure changes in this release), please update this section accordingly.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
33-33: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
35-35: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
36-36: Unordered list indentation
Expected: 2; Actual: 4(MD007, ul-indent)
|
3 participants
OSDEV-1787 The tooltip messages for the Claim button have been removed for all statuses of moderation events on the
Contribution Recordpage and changed according to the design onThanks for adding data for this production locationpop-up.For pending status to "There is a pending claim for this production location."
In the rest of the cases (exclude pending and claimed statuses - "You'll be able to claim the location after the moderation is done."