Skip to content

Fix VideoQnA#1696

Merged
xiguiw merged 46 commits intoopea-project:mainfrom
cwlacewe:videoqna-bug
Apr 12, 2025
Merged

Fix VideoQnA#1696
xiguiw merged 46 commits intoopea-project:mainfrom
cwlacewe:videoqna-bug

Conversation

@cwlacewe
Copy link
Copy Markdown
Contributor

@cwlacewe cwlacewe commented Mar 19, 2025

Description

This PR fixes the VideoQnA example.

Issues

Fixes #1476 #1478 #1477
Depends on GenAIComps PR#1317

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

cd VideoQnA/tests
export HF_TOKEN=<Huggingface token>
./test_compose_on_xeon.sh

@cwlacewe cwlacewe requested a review from XinyaoWa as a code owner March 19, 2025 11:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

This was referenced Mar 19, 2025
Merged
Closed
xiguiw
xiguiw reviewed Apr 2, 2025
View reviewed changes
@cwlacewe cwlacewe requested review from chensuyue and xiguiw April 3, 2025 07:53
xiguiw
xiguiw reviewed Apr 3, 2025
View reviewed changes
Spycsh
Spycsh reviewed Apr 3, 2025
View reviewed changes
@joshuayao joshuayao added this to the v1.3 milestone Apr 8, 2025
@lvliang-intel
Copy link
Copy Markdown
Collaborator

lvliang-intel commented Apr 9, 2025

@cwlacewe,
please fix the CI issue.
image

@joshuayao joshuayao added this to OPEA Apr 9, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 9, 2025
@joshuayao joshuayao added the bug Something isn't working label Apr 9, 2025
@joshuayao joshuayao linked an issue Apr 9, 2025 that may be closed by this pull request
[Bug] VideoQnA failed on Xeon #1477
Closed
8 tasks
@yinghu5
Copy link
Copy Markdown
Collaborator

yinghu5 commented Apr 10, 2025

@cwlacewe one CI for VideoQnA failed. could you please check?
[2025-04-10 02:56:33,543] [ ERROR] - opea_dataprep_multimodal_microservice - Error during dataprep ingest videos invocation: openai/clip-vit-base-patch32 does not appear to have a file named pytorch_model.bin but there is a file for TensorFlow weights. Use from_tf=True to load this model from those weights.
ERROR: Exception in ASGI application
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
result = await app( # type: ignore[func-returns-value]

@joshuayao joshuayao added the v1.3 label Apr 11, 2025
@xiguiw
Copy link
Copy Markdown
Collaborator

xiguiw commented Apr 11, 2025

CI failure:
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Permission denied

[2025-04-11 08:21:57,549] [    INFO] - opea_dataprep_vdms_multimodal - Connecting to vdms at 10.244.159.163:8001
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
[2025-04-11 08:21:58,100] [   ERROR] - opea_dataprep_multimodal_microservice - Error during dataprep ingest videos invocation: openai/clip-vit-base-patch32 does not appear to have a file named pytorch_model.bin but there is a file for TensorFlow weights. Use `from_tf=True` to load this model from those weights.
ERROR:    Exception in ASGI application

zhanmyz and others added 5 commits April 11, 2025 16:31
@zhanmyz @cwlacewe
Iteratively add image docker hub description (opea-project#1768)
6c3aabd 
Signed-off-by: zhanmyz <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @cwlacewe
Adaptation to vllm v0.8.3 build paths (opea-project#1761)
fca6693 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@eero-t @chensuyue @cwlacewe
Use GenAIComp base image to simplify Dockerfiles & reduce image sizes (…
afaa220 
…opea-project#1369)

Signed-off-by: Eero Tamminen <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Fix VideoQnA
b6af1f5 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@pre-commit-ci @cwlacewe
[pre-commit.ci] auto fixes from pre-commit.com hooks
b325af7 
for more information, see https://pre-commit.ci

Signed-off-by: Lacewell, Chaunte W <[email protected]>
ZePan110 and others added 25 commits April 11, 2025 16:51
@ZePan110 @cwlacewe
Enable model cache for Rocm docker compose test. (opea-project#1614)
aeb6e2c 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@minmin-intel @cwlacewe
fix bugs in DocIndexRetriever (opea-project#1770)
9da815e 
Signed-off-by: minmin-intel <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @chensuyue @cwlacewe
Enable AvatarChatbot model cache for docker compose test. (opea-proje…
ad46876 
…ct#1604)

Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @ashahba @cwlacewe
Unified build.yaml file writing style (opea-project#1781)
856653c 
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Abolfazl Shahbazi <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@XinyaoWa @sys-lpot-val @cwlacewe
Align DocSum env to vllm (opea-project#1784)
606e712 
Signed-off-by: sys-lpot-val <[email protected]>
Co-authored-by: sys-lpot-val <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@chensuyue @cwlacewe
Add new secrets for docker compose test (opea-project#1786)
2faf72d 
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @cwlacewe
Update model cache for MultimodalQnA (opea-project#1618)
7f8e7fb 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @cwlacewe
Redefine docker images list. (opea-project#1743)
753fe75 
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@ZePan110 @chensuyue @cwlacewe
[Translation] Integrate set_env.sh into test scripts. (opea-project#1785
72bba35 
)

Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@xiguiw @cwlacewe
Update compose.yaml
fc97a13 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@xiguiw @cwlacewe
Update compose.yaml
15a7f7b 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@xiguiw @cwlacewe
Update compose.yaml
e87b7d0 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@minmin-intel @pre-commit-ci @cwlacewe
update AgentQnA (opea-project#1790)
acf4bc7 
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Add tag to VDMS container instead of latest
e4438d3 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Address review comments: - Revert vdms tag change since latest tag is…
dcdd5a0 
… always latest stable version; - Minor updates in README; - Remove debug logs from videoqna.py; - Revert mounting volumes

Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Added cache volumes back as requested during review
0b51615 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Revert volumes to original values (no env var); try to resolve permis…
492a6b7 
…sion denied error with clip model in CI

Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Add tag to VDMS container instead of latest
8076302 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Address review comments: - Revert vdms tag change since latest tag is…
b4a84ef 
… always latest stable version; - Minor updates in README; - Remove debug logs from videoqna.py; - Revert mounting volumes

Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Added cache volumes back as requested during review
f8fcb80 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Revert volumes to original values (no env var); try to resolve permis…
b4b44a7 
…sion denied error with clip model in CI

Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Create volume to fix permission issue for .cache directory
58a1716 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Merge branch 'videoqna-bug' of https://github.com/cwlacewe/GenAIExamples
9598bfb 
 into videoqna-bug
@cwlacewe
Update README to match test
fc1a746 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe
Fix compose volumes and permission for them
5267dd0 
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@xiguiw xiguiw merged commit c476343 into opea-project:main Apr 12, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 12, 2025
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
@cwlacewe @chyundunovDatamonsters
Fix VideoQnA (opea-project#1696)
cc23fb9 
This PR fixes the VideoQnA example.

Fixes Issues opea-project#1476 opea-project#1478 opea-project#1477

Signed-off-by: zhanmyz <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
@lianhao
dataprep: return same type of data in get_tables_result (#1696)
6514236 
Return the same type of data in get_tables_result() to fix issue #1695

Signed-off-by: Lianhao Lu <[email protected]>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
@cwlacewe @cogniware-devops
Fix VideoQnA (opea-project#1696)
dceaba2 
This PR fixes the VideoQnA example.

Fixes Issues opea-project#1476 opea-project#1478 opea-project#1477

Signed-off-by: zhanmyz <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: cogniware-devops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spycsh Spycsh Spycsh approved these changes

@xiguiw xiguiw xiguiw approved these changes

@XinyaoWa XinyaoWa Awaiting requested review from XinyaoWa

@chensuyue chensuyue Awaiting requested review from chensuyue

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel

@rbrugaro rbrugaro Awaiting requested review from rbrugaro

@ashahba ashahba Awaiting requested review from ashahba

@myqi myqi Awaiting requested review from myqi

@letonghan letonghan Awaiting requested review from letonghan

@lkk12014402 lkk12014402 Awaiting requested review from lkk12014402

@xuechendi xuechendi Awaiting requested review from xuechendi

@WenjiaoYue WenjiaoYue Awaiting requested review from WenjiaoYue

@minmin-intel minmin-intel Awaiting requested review from minmin-intel

@ZePan110 ZePan110 Awaiting requested review from ZePan110

@ftian1 ftian1 Awaiting requested review from ftian1

Assignees

No one assigned

Labels

bug Something isn't working v1.3

Projects

OPEA
Status: Done

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

[Bug] VideoQnA failed on Xeon