fix bugs in DocIndexRetriever#1770
Merged
chensuyue merged 11 commits intoopea-project:mainfrom Apr 10, 2025
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
DocIndexRetriever/docker_compose/intel/hpu/gaudi/compose.yaml:91
- The environment variable 'HUGGINGFACEHUB_API_TOKEN' does not match the naming referenced in the PR description ('HUGGINGFACE_API_TOKEN'). Consider verifying and aligning the variable name to avoid potential confusion.
HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
DocIndexRetriever/docker_compose/intel/cpu/xeon/compose.yaml:31
- [nitpick] Ensure that the change from TEI_ENDPOINT to TEI_EMBEDDING_ENDPOINT is consistently applied across all related environments and matches the intended naming convention as per project standards.
TEI_EMBEDDING_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
Signed-off-by: minmin-intel <minmin.hou@intel.com>
lkk12014402
approved these changes
Apr 8, 2025
Collaborator
chensuyue
reviewed
Apr 9, 2025
chensuyue
reviewed
Apr 9, 2025
chensuyue
reviewed
Apr 9, 2025
Collaborator
Author
@lkk12014402 Are you still seeing this problem? I didn't encounter such problem when testing on my system. Did you use the latest GenAIComps? |
Signed-off-by: minmin-intel <minmin.hou@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
…n-intel/GenAIExamples into docindexretriever-fix-v1.3
chensuyue
approved these changes
Apr 10, 2025
cwlacewe
pushed a commit
to cwlacewe/GenAIExamples
that referenced
this pull request
Apr 11, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com> Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
cwlacewe
pushed a commit
to cwlacewe/GenAIExamples
that referenced
this pull request
Apr 11, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com> Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan
pushed a commit
that referenced
this pull request
Sep 17, 2025
optimum version change cause vllm OpenVINO fails to load model Fix #1770 Signed-off-by: Wang, Xigui <xigui.wang@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.