Skip to content

fix bugs in DocIndexRetriever#1770

Merged
chensuyue merged 11 commits intoopea-project:mainfrom
minmin-intel:docindexretriever-fix-v1.3
Apr 10, 2025
Merged

fix bugs in DocIndexRetriever#1770
chensuyue merged 11 commits intoopea-project:mainfrom
minmin-intel:docindexretriever-fix-v1.3

Conversation

@minmin-intel
Copy link
Copy Markdown
Collaborator

Description

  1. docker compose for xeon: dataprep TEI_ENDPOINT -> TEI_EMBEDDING_ENDPOINT
  2. docker compose for gaudi: dataprep TEI_ENDPOINT -> TEI_EMBEDDING_ENDPOINT, retriever: add TEI_EMBEDDING_ENDPOINT and HUGGINGFACE_API_TOKEN env vars

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copilot AI review requested due to automatic review settings April 7, 2025 18:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

DocIndexRetriever/docker_compose/intel/hpu/gaudi/compose.yaml:91

  • The environment variable 'HUGGINGFACEHUB_API_TOKEN' does not match the naming referenced in the PR description ('HUGGINGFACE_API_TOKEN'). Consider verifying and aligning the variable name to avoid potential confusion.
HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}

DocIndexRetriever/docker_compose/intel/cpu/xeon/compose.yaml:31

  • [nitpick] Ensure that the change from TEI_ENDPOINT to TEI_EMBEDDING_ENDPOINT is consistently applied across all related environments and matches the intended naming convention as per project standards.
TEI_EMBEDDING_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}

Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
@joshuayao joshuayao added this to the v1.3 milestone Apr 8, 2025
@lkk12014402
Copy link
Copy Markdown
Collaborator

still have a issue with command

curl http://${host_ip}:8889/v1/retrievaltool -X POST -H "Content-Type: application/json" -d '{
     "messages": "Explain the OPEA project?"
     }'

image

@joshuayao joshuayao requested a review from rbrugaro April 9, 2025 01:43
@joshuayao joshuayao added this to OPEA Apr 9, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 9, 2025
@joshuayao joshuayao added the bug Something isn't working label Apr 9, 2025
@minmin-intel
Copy link
Copy Markdown
Collaborator Author

still have a issue with command

curl http://${host_ip}:8889/v1/retrievaltool -X POST -H "Content-Type: application/json" -d '{
     "messages": "Explain the OPEA project?"
     }'

image

@lkk12014402 Are you still seeing this problem? I didn't encounter such problem when testing on my system. Did you use the latest GenAIComps?

minmin-intel and others added 6 commits April 9, 2025 17:33
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
@chensuyue chensuyue merged commit 411bb28 into opea-project:main Apr 10, 2025
26 of 27 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 10, 2025
cwlacewe pushed a commit to cwlacewe/GenAIExamples that referenced this pull request Apr 11, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
cwlacewe pushed a commit to cwlacewe/GenAIExamples that referenced this pull request Apr 11, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
optimum version change cause vllm OpenVINO fails to load model

Fix #1770

Signed-off-by: Wang, Xigui <xigui.wang@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants