Skip to content

update AgentQnA#1790

Merged
minmin-intel merged 2 commits intoopea-project:mainfrom
minmin-intel:agentqna-fix-v1.3
Apr 11, 2025
Merged

update AgentQnA#1790
minmin-intel merged 2 commits intoopea-project:mainfrom
minmin-intel:agentqna-fix-v1.3

Conversation

@minmin-intel
Copy link
Copy Markdown
Collaborator

Description

  1. Update worker RAG agent search_knowledge_base tool with the latest changes in DocIndexRetriever
  2. Update README: clean up, add more instructions regarding UI
  3. Build DocIndexRetriever related docker images in unit test instead of pulling to reflect the latest changes

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copilot AI review requested due to automatic review settings April 10, 2025 23:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • AgentQnA/retrieval_tool/run_ingest_data.sh: Language not supported
  • AgentQnA/tests/step4_launch_and_validate_agent_gaudi.sh: Language not supported
  • AgentQnA/tests/test_compose_on_gaudi.sh: Language not supported
Comments suppressed due to low confidence (2)

AgentQnA/tools/worker_agent_tools.py:15

  • Ensure that the change from using the 'text' key to 'messages' in the payload aligns with the updated API requirements for DocIndexRetriever to avoid any integration issues.
"messages": query,

AgentQnA/docker_compose/intel/hpu/gaudi/compose.yaml:141

  • Confirm that the revised command flag '--max-seq-len-to-capture' matches the expected parameter name in the underlying system, ensuring consistency with the updated configuration.
command: --model $LLM_MODEL_ID --tensor-parallel-size 4 --host 0.0.0.0 --port 8000 --block-size 128 --max-num-seqs 256 --max-seq-len-to-capture 16384

@joshuayao joshuayao added this to OPEA Apr 11, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 11, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 11, 2025
@joshuayao joshuayao added the v1.3 label Apr 11, 2025
@minmin-intel minmin-intel merged commit 58b47c1 into opea-project:main Apr 11, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 11, 2025
cwlacewe pushed a commit to cwlacewe/GenAIExamples that referenced this pull request Apr 11, 2025
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
cwlacewe pushed a commit to cwlacewe/GenAIExamples that referenced this pull request Apr 11, 2025
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <[email protected]>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: cogniware-devops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants