MSC3773: Notifications for threads by clokep · Pull Request #3773 · matrix-org/matrix-spec-proposals

clokep · 2022-04-15T18:07:20Z

Rendered

Implementations:

Synapse: Track notification counts per thread (implement MSC3773) (redo) synapse#13776
Element Web: Threads notification proof of concept (MSC3773) matrix-js-sdk#2600 / Threads notification proof of concept (MSC3773) matrix-react-sdk#9204

FCP tickyboxes

proposals/3773-notifications-for-threads.md

dbkr

With my client hat on, this looks fine, and is simple and solve the problem in question. One minor nitpick could be a note saying that it only seeks to address the counts in the sync response, rather than content of any actual notifications sent (which I think is the correct decision).

proposals/3773-notifications-for-threads.md

mscbot · 2022-09-18T19:16:47Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

turt2live · 2022-09-27T04:38:55Z

Spec PR: matrix-org/matrix-spec#1255

turt2live · 2022-09-28T20:49:47Z

Merged 🎉

Upstream changes: Synapse 1.70.1 (2022-10-28) =========================== (bugfixes) Synapse 1.70.0 (2022-10-26) =========================== Features -------- - Support for [MSC3856](matrix-org/matrix-spec-proposals#3856): threads list API. ([\#13394](matrix-org/synapse#13394), [\#14171](matrix-org/synapse#14171), [\#14175](matrix-org/synapse#14175)) - Support for thread-specific notifications & receipts ([MSC3771](matrix-org/matrix-spec-proposals#3771) and [MSC3773](matrix-org/matrix-spec-proposals#3773)). ([\#13776](matrix-org/synapse#13776), [\#13824](matrix-org/synapse#13824), [\#13877](matrix-org/synapse#13877), [\#13878](matrix-org/synapse#13878), [\#14050](matrix-org/synapse#14050), [\#14140](matrix-org/synapse#14140), [\#14159](matrix-org/synapse#14159), [\#14163](matrix-org/synapse#14163), [\#14174](matrix-org/synapse#14174), [\#14222](matrix-org/synapse#14222)) - Stop fetching missing `prev_events` after we already know their signature is invalid. ([\#13816](matrix-org/synapse#13816)) - Send application service access tokens as a header (and query parameter). Implements [MSC2832](matrix-org/matrix-spec-proposals#2832). ([\#13996](matrix-org/synapse#13996)) - Ignore server ACL changes when generating pushes. Implements [MSC3786](matrix-org/matrix-spec-proposals#3786). ([\#13997](matrix-org/synapse#13997)) - Experimental support for redirecting to an implementation of a [MSC3886](matrix-org/matrix-spec-proposals#3886) HTTP rendezvous service. ([\#14018](matrix-org/synapse#14018)) - The `/relations` endpoint can now be used on workers. ([\#14028](matrix-org/synapse#14028)) - Advertise support for Matrix 1.3 and 1.4 on `/_matrix/client/versions`. ([\#14032](matrix-org/synapse#14032), [\#14184](matrix-org/synapse#14184)) - Improve validation of request bodies for the [Device Management](https://spec.matrix.org/v1.4/client-server-api/#device-management) and [MSC2697 Device Dehyrdation](matrix-org/matrix-spec-proposals#2697) client-server API endpoints. ([\#14054](matrix-org/synapse#14054)) - Experimental support for [MSC3874](matrix-org/matrix-spec-proposals#3874): Filtering threads from the `/messages` endpoint. ([\#14148](matrix-org/synapse#14148)) - Improve the validation of the following PUT endpoints: [`/directory/room/{roomAlias}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directoryroomroomalias), [`/directory/list/room/{roomId}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directorylistroomroomid) and [`/directory/list/appservice/{networkId}/{roomId}`](https://spec.matrix.org/v1.4/application-service-api/#put_matrixclientv3directorylistappservicenetworkidroomid). ([\#14179](matrix-org/synapse#14179)) Deprecations and Removals ------------------------- - Remove the experimental implementation of [MSC3772](matrix-org/matrix-spec-proposals#3772). ([\#14094](matrix-org/synapse#14094)) - Remove the unstable identifier for [MSC3715](matrix-org/matrix-spec-proposals#3715). ([\#14106](matrix-org/synapse#14106), [\#14146](matrix-org/synapse#14146))

Add initial MSC for notfications for threads.

720ff50

turt2live added push proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 15, 2022

No longer depends on MSC3664.

5ca370a

Johennes reviewed Apr 20, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

Johennes reviewed Apr 20, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Show resolved Hide resolved

t3chguy reviewed Apr 20, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

t3chguy reviewed Apr 20, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

t3chguy reviewed Apr 20, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

Fix events in diagram.

941b65d

clokep mentioned this pull request Apr 25, 2022

Threads: Improve Notifications for Exit Beta element-hq/element-meta#196

Closed

6 tasks

clokep added 2 commits June 16, 2022 12:08

Major simplification.

b4755fc

Add missing words.

8edb4ec

clokep mentioned this pull request Jul 25, 2022

Notifications for threads matrix-org/synapse#12550

Closed

11 tasks

This was referenced Aug 3, 2022

Notifications for threads proof of concept element-hq/element-web#22981

Closed

Threads: Exit Beta element-hq/element-meta#187

Closed

Add a note about reactions.

c88d910

clokep marked this pull request as ready for review August 8, 2022 18:53

dbkr approved these changes Aug 9, 2022

View reviewed changes

erikjohnston reviewed Aug 17, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

This was referenced Aug 18, 2022

Threads notification proof of concept (MSC3773) matrix-org/matrix-js-sdk#2600

Closed

Threads notification proof of concept (MSC3773) matrix-org/matrix-react-sdk#9203

Closed

Threads notification proof of concept (MSC3773) matrix-org/matrix-react-sdk#9204

Closed

Clarify homeserver behavior when processing push rules.

94bf9ac

clokep commented Aug 31, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Show resolved Hide resolved

clokep commented Aug 31, 2022

View reviewed changes

proposals/3773-notifications-for-threads.md Outdated Show resolved Hide resolved

germain-gg mentioned this pull request Sep 2, 2022

Implement MSC3773 (notifications for threads) element-hq/element-web#23192

Closed

Update how homeservers are to partition threads.

3f2d435

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Sep 18, 2022

turt2live merged commit 9d80dcb into main Sep 20, 2022

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Sep 20, 2022

turt2live self-assigned this Sep 26, 2022

turt2live mentioned this pull request Sep 27, 2022

Threads: Read receipts & notifications matrix-org/matrix-spec#1255

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 27, 2022

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 28, 2022

This was referenced Sep 30, 2022

Implement MSC3773: Notifications for threads ruma/ruma#1308

Closed

Incorporate Matrix version 1.4 changes ruma/ruma#1278

Closed

client-api: Add support for notifications for threads ruma/ruma#1324

Merged

This was referenced Oct 3, 2022

Add support for unread thread notifications matrix-org/matrix-js-sdk#2726

Merged

Cannot persistently clear unread messages in rooms containing threads element-hq/element-web#21114

Closed

MTRNord mentioned this pull request Oct 12, 2022

psycopg2.errors.UniqueViolation: could not create unique index "receipts_graph_unique_index" matrix-org/synapse#14123

Closed

This was referenced Oct 17, 2022

threads read receipt and unread notifications server capability validation element-hq/element-meta#774

Closed

threads read receipt and unread notifications server capability validation element-hq/element-android#7385

Closed

germain-gg mentioned this pull request Jan 30, 2023

Cleanup pre MSC3773 thread unread notif logic matrix-org/matrix-react-sdk#10023

Merged

3 tasks

jdauphant mentioned this pull request Apr 3, 2023

En tant qu'utilisateur, je souhaite répondre dans un fils de discussion afin d'avoir une meilleure gestion des discussions tchapgouv/tchap-web-v4#522

Open

clokep deleted the clokep/threads-notifications branch May 17, 2023 12:21

S7evinK mentioned this pull request Oct 2, 2023

Declare support for Matrix 1.4 matrix-org/dendrite#3222

Open

14 tasks

matrixbot mentioned this pull request Nov 1, 2024

Declare support for Matrix 1.4 element-hq/dendrite#3222

Open

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC3773: Notifications for threads#3773

MSC3773: Notifications for threads#3773
turt2live merged 11 commits intomainfrom
clokep/threads-notifications

clokep commented Apr 15, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbkr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mscbot commented Sep 18, 2022

Uh oh!

turt2live commented Sep 27, 2022

Uh oh!

turt2live commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

clokep commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbkr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mscbot commented Sep 18, 2022

Uh oh!

turt2live commented Sep 27, 2022

Uh oh!

turt2live commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

clokep commented Apr 15, 2022 •

edited

Loading