MSC3856: Threads List API by clokep · Pull Request #3856 · matrix-org/matrix-spec-proposals

clokep · 2022-07-26T16:56:45Z

Implementations:

Synapse: Add an API for listing threads in a room. synapse#13394
matrix-js-sdk: Load Thread List with server-side assistance (MSC3856) matrix-js-sdk#2602

proposals/3856-threads-list-api.md

richvdh

A few comments, but generally looks sensible to me. If you could clarify a couple of things we can probably put this up for FCP.

proposals/3856-threads-list-api.md

Co-authored-by: Richard van der Hoff <[email protected]>

kegsay · 2022-08-22T14:17:06Z

proposals/3856-threads-list-api.md

@@ -0,0 +1,182 @@
+# MSC3856: Threads List API


How does this work over federation as the local server may not have all the thread roots?

It does not change any behavior there -- a server could backfill to fetch additional thread roots if it wanted to, but that seems rather implementation specific.

kegsay · 2022-08-22T14:18:31Z

proposals/3856-threads-list-api.md

+[MSC3440](https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3440-threading-via-relations.md#event-format)
+for the format of bundled aggregations of threads).
+
+The returned events are ordered by the latest event of each thread.


Latest by what metric? origin_server_ts? Arrival time on the server? Topological ordering?

This is meant to be rather vague and it is further defined below under chunk, although that doesn't fully answer the question either:

The order is chronological by the latest event in that thread.

Note that this is mostly copied from the chunk definition of /messages, which includes the following text:

(The exact definition of chronological is dependent on the server implementation.)

proposals/3856-threads-list-api.md

germain-gg · 2022-09-05T17:39:38Z

Proof of client side implementation for this proposal, matrix-org/matrix-js-sdk#2602

turt2live · 2022-09-05T17:54:41Z

The people involved here believe this is ready for FCP. Implementations have not been checked yet though: if suitable, the label will be removed and review continue. If not suitable, comments will be left.

turt2live

Generally seems fine to me, though I'm not looking forward to specifying another pagination API 🙃

That's a future problem, though.

proposals/3856-threads-list-api.md

turt2live · 2022-09-06T19:14:22Z

@mscbot fcp merge

mscbot · 2022-09-06T19:14:24Z

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

~~should we care about further updates to the threads list on the client side? Notably wrt messages from ignored users~~

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

KitsuneRal · 2022-09-20T19:58:35Z

The concern is formally resolved in order to let the FCP start and the threads get into the spec within this cycle, with a caveat that we will either fix the logic for ignored events or document the discrepancy I described in the comment as a known issue (that will be addressed in a separate MSC).

mscbot · 2022-09-25T19:49:01Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

turt2live · 2022-09-27T04:37:31Z

Spec PR: matrix-org/matrix-spec#1254

turt2live · 2022-09-27T19:51:54Z

Merged 🎉

Upstream changes: Synapse 1.70.1 (2022-10-28) =========================== (bugfixes) Synapse 1.70.0 (2022-10-26) =========================== Features -------- - Support for [MSC3856](matrix-org/matrix-spec-proposals#3856): threads list API. ([\#13394](matrix-org/synapse#13394), [\#14171](matrix-org/synapse#14171), [\#14175](matrix-org/synapse#14175)) - Support for thread-specific notifications & receipts ([MSC3771](matrix-org/matrix-spec-proposals#3771) and [MSC3773](matrix-org/matrix-spec-proposals#3773)). ([\#13776](matrix-org/synapse#13776), [\#13824](matrix-org/synapse#13824), [\#13877](matrix-org/synapse#13877), [\#13878](matrix-org/synapse#13878), [\#14050](matrix-org/synapse#14050), [\#14140](matrix-org/synapse#14140), [\#14159](matrix-org/synapse#14159), [\#14163](matrix-org/synapse#14163), [\#14174](matrix-org/synapse#14174), [\#14222](matrix-org/synapse#14222)) - Stop fetching missing `prev_events` after we already know their signature is invalid. ([\#13816](matrix-org/synapse#13816)) - Send application service access tokens as a header (and query parameter). Implements [MSC2832](matrix-org/matrix-spec-proposals#2832). ([\#13996](matrix-org/synapse#13996)) - Ignore server ACL changes when generating pushes. Implements [MSC3786](matrix-org/matrix-spec-proposals#3786). ([\#13997](matrix-org/synapse#13997)) - Experimental support for redirecting to an implementation of a [MSC3886](matrix-org/matrix-spec-proposals#3886) HTTP rendezvous service. ([\#14018](matrix-org/synapse#14018)) - The `/relations` endpoint can now be used on workers. ([\#14028](matrix-org/synapse#14028)) - Advertise support for Matrix 1.3 and 1.4 on `/_matrix/client/versions`. ([\#14032](matrix-org/synapse#14032), [\#14184](matrix-org/synapse#14184)) - Improve validation of request bodies for the [Device Management](https://spec.matrix.org/v1.4/client-server-api/#device-management) and [MSC2697 Device Dehyrdation](matrix-org/matrix-spec-proposals#2697) client-server API endpoints. ([\#14054](matrix-org/synapse#14054)) - Experimental support for [MSC3874](matrix-org/matrix-spec-proposals#3874): Filtering threads from the `/messages` endpoint. ([\#14148](matrix-org/synapse#14148)) - Improve the validation of the following PUT endpoints: [`/directory/room/{roomAlias}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directoryroomroomalias), [`/directory/list/room/{roomId}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directorylistroomroomid) and [`/directory/list/appservice/{networkId}/{roomId}`](https://spec.matrix.org/v1.4/application-service-api/#put_matrixclientv3directorylistappservicenetworkidroomid). ([\#14179](matrix-org/synapse#14179)) Deprecations and Removals ------------------------- - Remove the experimental implementation of [MSC3772](matrix-org/matrix-spec-proposals#3772). ([\#14094](matrix-org/synapse#14094)) - Remove the unstable identifier for [MSC3715](matrix-org/matrix-spec-proposals#3715). ([\#14106](matrix-org/synapse#14106), [\#14146](matrix-org/synapse#14146))

clokep changed the title ~~MSC3855: Threads List API~~ MSC3856: Threads List API Jul 26, 2022

Initial MSC3856 draft.

805c0b2

clokep force-pushed the clokep/threads-list-api branch from 257f842 to 805c0b2 Compare July 26, 2022 16:58

clokep mentioned this pull request Jul 26, 2022

Add an API for listing threads in a room. matrix-org/synapse#13394

Merged

turt2live added proposal A matrix spec change proposal kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 26, 2022

This was referenced Jul 27, 2022

Load the thread list using server-side sorting and pagination element-hq/element-meta#195

Closed

My Threads: Thread replies to root messages going unnoticed element-hq/element-meta#235

Closed

s/filter/include/g

be44a1f

clokep commented Jul 27, 2022

View reviewed changes

proposals/3856-threads-list-api.md Outdated Show resolved Hide resolved

clokep marked this pull request as ready for review July 28, 2022 12:08

germain-gg mentioned this pull request Aug 3, 2022

Threads: Exit Beta element-hq/element-meta#187

Closed

richvdh reviewed Aug 9, 2022

View reviewed changes

clokep and others added 5 commits August 9, 2022 15:37

Fix typo.

5af798d

Co-authored-by: Richard van der Hoff <[email protected]>

Add link to the current spec.

89a6146

Co-authored-by: Richard van der Hoff <[email protected]>

Link to MSC3440 for related_by_rel_types.

d51209a

Rework and clarify intro.

8ef8232

Clarify what is returned by the API.

75afe34

clokep force-pushed the clokep/threads-list-api branch from fdfa26b to 75afe34 Compare August 18, 2022 12:56

clokep added 2 commits August 18, 2022 08:59

Add a note on dir.

f23162d

Add info on ignored users.

dd11005

kegsay reviewed Aug 22, 2022

View reviewed changes

turt2live added client-server Client-Server API and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 6, 2022

turt2live approved these changes Sep 6, 2022

View reviewed changes

proposals/3856-threads-list-api.md Outdated Show resolved Hide resolved

proposals/3856-threads-list-api.md Outdated Show resolved Hide resolved

proposals/3856-threads-list-api.md Outdated Show resolved Hide resolved

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Sep 25, 2022

turt2live merged commit aa51353 into main Sep 25, 2022

turt2live self-assigned this Sep 26, 2022

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Sep 26, 2022

turt2live mentioned this pull request Sep 27, 2022

Threads: The base matrix-org/matrix-spec#1254

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 27, 2022

clokep mentioned this pull request Sep 27, 2022

Implement MSC3856, a threads list API matrix-org/synapse#13921

Closed

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 27, 2022

germain-gg mentioned this pull request Oct 18, 2022

Threads are missing from the threads list element-hq/element-web#21911

Closed

jdauphant mentioned this pull request Apr 3, 2023

En tant qu'utilisateur, je souhaite répondre dans un fils de discussion afin d'avoir une meilleure gestion des discussions tchapgouv/tchap-web-v4#522

Open

clokep deleted the clokep/threads-list-api branch May 17, 2023 12:21

S7evinK mentioned this pull request Oct 2, 2023

Declare support for Matrix 1.4 matrix-org/dendrite#3222

Open

14 tasks

necropola mentioned this pull request Dec 12, 2023

Dendrite sends read receipts regardless of user preference matrix-org/dendrite#3284

Open

This was referenced Nov 1, 2024

Declare support for Matrix 1.4 element-hq/dendrite#3222

Open

Dendrite sends read receipts regardless of user preference element-hq/dendrite#3284

Closed

Conversation

clokep commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

richvdh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kegsay Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

clokep Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

kegsay Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

clokep Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

germain-gg commented Sep 5, 2022

Uh oh!

turt2live commented Sep 5, 2022

Uh oh!

turt2live left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

turt2live commented Sep 6, 2022

Uh oh!

mscbot commented Sep 6, 2022 • edited by KitsuneRal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KitsuneRal commented Sep 20, 2022

Uh oh!

mscbot commented Sep 25, 2022

Uh oh!

turt2live commented Sep 27, 2022

Uh oh!

turt2live commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

clokep commented Jul 26, 2022 •

edited

Loading

mscbot commented Sep 6, 2022 •

edited by KitsuneRal

Loading