Threads: Read receipts & notifications#1255
Merged
Conversation
Note: this builds on a (as of writing) non-existent "threading" section, which is part of a different commit.
Merged
This was referenced Sep 27, 2022
germain-gg
reviewed
Sep 27, 2022
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Looks great! I added non blocking minor comments
clokep
reviewed
Sep 27, 2022
Member
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
Looks good overall! Thanks for writing this up! 👍
| [Receiving notifications](#receiving-notifications) section for more | ||
| information on how read receipts affect notification counts. | ||
|
|
||
| {{< added-in v="1.4" >}} Read receipts exist in three major forms: |
Member
There was a problem hiding this comment.
MSC3771 doesn't specify that unthreaded/threaded applies only to read receipts, but there isn't currently any other type of receipts...
Member
Author
There was a problem hiding this comment.
yea, we're very slowly moving this module to talk about only read receipts at the moment (at least until another receipt shows up)
Member
There was a problem hiding this comment.
Makes sense, just wanted to ensure this was on purpose.
dbkr
approved these changes
Sep 27, 2022
turt2live
requested review from
clokep,
dbkr,
erikjohnston and
germain-gg
and removed request for
clokep and
germain-gg
Member
Author
|
@dbkr not sure if your approval was unconditional or not, between yourself and @erikjohnston I'll take whatever though :) @clokep @gsouquet for some reason github hates me and will only let me re-request review from one of you. Given you both had feedback, please take a look at the changes. |
Member
|
Yep, still lgtm |
germain-gg
approved these changes
Sep 28, 2022
This was referenced Sep 30, 2022
zecakeh
added a commit
to zecakeh/matrix-spec
that referenced
this pull request
Oct 1, 2022
It seems to have been omitted in matrix-org#1255
zecakeh
added a commit
to zecakeh/matrix-spec
that referenced
this pull request
Oct 1, 2022
It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <[email protected]>
This was referenced Oct 2, 2022
turt2live
added a commit
that referenced
this pull request
Oct 4, 2022
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in #1255 Signed-off-by: Kévin Commaille <[email protected]> * changelog Signed-off-by: Kévin Commaille <[email protected]> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <[email protected]> Signed-off-by: Kévin Commaille <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
turt2live
added a commit
that referenced
this pull request
Oct 4, 2022
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in #1255 Signed-off-by: Kévin Commaille <[email protected]> * changelog Signed-off-by: Kévin Commaille <[email protected]> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <[email protected]> Signed-off-by: Kévin Commaille <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Spec MSC3771: Threaded read receipts Note: this builds on a (as of writing) non-existent "threading" section, which is part of a different commit. * Spec MSC3773: Threaded notifications * changelog * Various clarifications per review
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Receipts: Add thread_id to the /receipt endpoint It seems to have been omitted in matrix-org#1255 Signed-off-by: Kévin Commaille <[email protected]> * changelog Signed-off-by: Kévin Commaille <[email protected]> * Fix missing backtick * Apply suggestion for error description Co-authored-by: Travis Ralston <[email protected]> Signed-off-by: Kévin Commaille <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifies matrix-org/matrix-spec-proposals#3771
Specifies matrix-org/matrix-spec-proposals#3773
This is reviewable commit-by-commit, for each of the MSCs listed above.
Note: This PR references a non-existent section called "Threading". That is specified by #1254 and thus this PR cannot land until 1254 does. Please see 1254 for details on what the "Threading" section entails.
Requires matrix-org/matrix-spec-proposals#3899 for clarifications.
Preview: https://pr1255--matrix-spec-previews.netlify.app