Closed
Conversation
Contributor
|
Can some other renames make it into the release to make the API more consistent? |
Collaborator
Author
|
Do you mean |
Owner
|
👍 |
Collaborator
Author
|
Published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, @indutny @calvinmetcalf thanks for trust and allowance to maintain this project. And sorry for delay.
Initially, I planned fill CHANGELOG.md and submit PR with minor version, but almost immediately I remembered that
masterbranch already have semver-major changes which was never published. So I decide:5.0.05.1.0and so on..6.0.0I'm not sure that I'll able finish
6.0.0, but I'll try do this.5.0.0can be considered as intermediate version. It's fastest way receive bn.js with patches from ~2 last years.--
@indutny @calvinmetcalf I'd prefer not release version
5.0.0without ACK. Are you ok with this plan?No need merge this PR, this mostly preview. If you agree with proposed process, I'll commit changes directly to master.
--
.modn()introduce.modrn()(modn API inconsistency #112 Breaking changes for the next major release #129 bn: make .modn() return a BN (fixes #112) #130)filesinsteadof.npmignore(Add section files to package.json #152)