Skip to content

readme: document strip() and toJSON()#105

Closed
axic wants to merge 1 commit intoindutny:masterfrom
axic:patch/readme-document-missing
Closed

readme: document strip() and toJSON()#105
axic wants to merge 1 commit intoindutny:masterfrom
axic:patch/readme-document-missing

Conversation

@axic
Copy link
Contributor

@axic axic commented Jan 24, 2016

No description provided.

@indutny
Copy link
Owner

indutny commented Jan 24, 2016

strip() should not be documented, IMO. I can't imagine a use case for it, as all operation should strip numbers automatically.

@axic
Copy link
Contributor Author

axic commented Jan 24, 2016

Shouldn't strip be underscore prefixed (as the other internal methods) in that case?

@indutny
Copy link
Owner

indutny commented Jan 24, 2016

This is a good idea.

@axic axic mentioned this pull request Feb 1, 2016
@axic
Copy link
Contributor Author

axic commented Feb 1, 2016

@indutny created a separate PR for strip and updated this one with a new patch: to document toJSON and make the readme clearer about the other export methods

@indutny
Copy link
Owner

indutny commented Feb 9, 2016

Landed and released, thank you!

@indutny indutny closed this Feb 9, 2016
@axic axic deleted the patch/readme-document-missing branch February 9, 2016 11:24
indutny pushed a commit that referenced this pull request Nov 29, 2017
ivanshukhov pushed a commit to Kapoio/bn.js that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants