Reject decimal input#91
Closed
axic wants to merge 3 commits intoindutny:masterfrom
axic:patch/reject-decimals
Closed
Reject decimal input#91axic wants to merge 3 commits intoindutny:masterfrom axic:patch/reject-decimals
axic wants to merge 3 commits intoindutny:masterfrom
axic:patch/reject-decimals
Conversation
Owner
|
Does it affect benchmarks? |
Contributor
Author
|
Seems like my comments didn't get posted here back in December. Unfortunately it does affect benchmarks so I was thinking about others ways to do it. Perhaps the best would be having two input functions: a safe (for "user input") and an unsafe one (for speed, e.g. the current implementation). Any ideas about an API for the above? |
Owner
|
I'm not sure about it myself. Perhaps, |
Closed
Owner
|
Preemptively added |
8 tasks
Collaborator
|
Why not land this PR in |
Owner
|
Landed test in 9173bc2, the issue was fixed in different commit. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #90