Skip to content

only define toBuffer if Buffer is defined#172

Merged
dcousens merged 2 commits intomasterfrom
bufbuf
Nov 30, 2017
Merged

only define toBuffer if Buffer is defined#172
dcousens merged 2 commits intomasterfrom
bufbuf

Conversation

@dcousens
Copy link
Contributor

@dcousens dcousens commented Nov 29, 2017 •
edited
Loading

Alternative to having a run-time check?

Error is more legible too, IMHO.

The existing error:

    if (!val) throw new Error(msg || 'Assertion failed');
              ^
Error: Assertion failed

The new

TypeError: mynum.toBuffer is not a function

@dcousens dcousens requested a review from indutny November 29, 2017 22:27
indutny
indutny approved these changes Nov 30, 2017
View reviewed changes
Copy link
Owner

@indutny indutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcousens dcousens merged commit ff8979b into master Nov 30, 2017
@dcousens dcousens deleted the bufbuf branch November 30, 2017 02:46
@fanatid fanatid mentioned this pull request Dec 23, 2019
Closed
@meck93 meck93 mentioned this pull request Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indutny indutny indutny approved these changes

Assignees

No one assigned

Labels

feature / refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcousens @indutny