-
Notifications
You must be signed in to change notification settings - Fork 115
release v2.0.0 #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v2.0.0 #685
Conversation
Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
…tion and unit tests (#609)
Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jessica Scheick <[email protected]>
… group (#629) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jessica Scheick <[email protected]>
Allows CI to pass and docs to build without getting stuck on import errors.
Co-authored-by: GitHub Action <[email protected]>
… group (#659) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…in a separate action (#661) Co-authored-by: Matt Fisher <[email protected]>
…ions (#617) Copy integration test workflow from earthaccess Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matt Fisher <[email protected]> Co-authored-by: Trey Stafford <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Theresa Andersen <[email protected]> Co-authored-by: asteiker <[email protected]> Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: Jessica Scheick <[email protected]> Co-authored-by: Rachel Wegener <[email protected]> Co-authored-by: Wei Ji <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I will automatically update this comment whenever this PR is modified |
weiji14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2! 🚀🚀
|
Don't have permission to merge into protected branch |
| API endpoint from the on-premises EGI system to the cloud-based Harmony services. | ||
| icepyx has been updated to access these new services; Certain capabilities are temporarily going away | ||
|
|
||
| * Data reformatting: users will only get HDF5 files back from the new API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the product is gridded (so natively a netcdf)? I assume this is referring to the fact that reformatting is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think if the product is gridded and supported by Harmony the trajectory subsetter cannot do the magic it does with other datasets like "I'd like the result in geoparquet" etc. So whatever the source file is that's the format of the output. Is this correct @asteiker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so maybe the comment should say "No file reformatting is available for now."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@betolink Yes that is correct, no reformatting is available in Harmony as of now, for any IS2 product. And, none of the gridded (L3B) products are hooked up to Harmony, so no services are available for those products, even subsetting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about something like this?
| * Data reformatting: users will only get HDF5 files back from the new API. | |
| * Data reformatting: Currently reformatting is not supported for any ICESat-2 products, so users will only get full HDF5 files back from the new Harmony API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stay with something along the lines of "no format transcoding is available" because "full HDF5" sounds like not even subsetting is an option. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Data reformatting: users will only get HDF5 files back from the new API. | |
| * Data reformatting: Currently no format transcoding is available for any ICESat-2 products, so users will only get HDF5 files back from the new Harmony API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we can't push these changes because the development branch is protected (and I don't think we have permissions to override it). I guess we'll just leave this as is, and update the changelog in a v2.0.1 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this sentence on the GitHub release notes at least - https://github.com/icesat2py/icepyx/releases/tag/v2.0.0. Cheers everyone for making this happen!
|
Note that upload of sdist/wheel to TestPyPI succeeded, but upload to PyPI failed due to an attestation file issue. I've manually downloaded the sdist/wheel from TestPyPI (https://test.pypi.org/project/icepyx/2.0.0/#files) and uploaded it to PyPI at https://pypi.org/project/icepyx/2.0.0/#files (hashsums should match). Also opened a PR at #687 to fix the publish-to-pypi.yml GitHub Action workflow so this won't happen again. |
v2.0.0 release for Icepyx with Harmony integration replacing the deprecated EGI subsetter. Details in the CHANGELOG, documentation and related issues in Github.