Skip to content

Conversation

@betolink
Copy link
Contributor

v2.0.0 release for Icepyx with Harmony integration replacing the deprecated EGI subsetter. Details in the CHANGELOG, documentation and related issues in Github.

mfisher87 and others added 30 commits September 17, 2024 17:48
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jessica Scheick <[email protected]>
… group (#629)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Allows CI to pass and docs to build without getting stuck on import errors.
… group (#659)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ions (#617)

Copy integration test workflow from earthaccess

Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
betolink and others added 2 commits May 9, 2025 11:35
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Trey Stafford <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Theresa Andersen <[email protected]>
Co-authored-by: asteiker <[email protected]>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: Jessica Scheick <[email protected]>
Co-authored-by: Rachel Wegener <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit 14a1372

I will automatically update this comment whenever this PR is modified

@betolink betolink marked this pull request as ready for review May 16, 2025 21:03
@weiji14 weiji14 changed the title v2.0.0 release release v2.0.0 May 17, 2025
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2! 🚀🚀

@weiji14
Copy link
Member

weiji14 commented May 17, 2025

Don't have permission to merge into protected branch main 😅 Need to wait for someone with higher permissions.

API endpoint from the on-premises EGI system to the cloud-based Harmony services.
icepyx has been updated to access these new services; Certain capabilities are temporarily going away

* Data reformatting: users will only get HDF5 files back from the new API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the product is gridded (so natively a netcdf)? I assume this is referring to the fact that reformatting is not available?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@betolink betolink May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think if the product is gridded and supported by Harmony the trajectory subsetter cannot do the magic it does with other datasets like "I'd like the result in geoparquet" etc. So whatever the source file is that's the format of the output. Is this correct @asteiker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so maybe the comment should say "No file reformatting is available for now."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betolink Yes that is correct, no reformatting is available in Harmony as of now, for any IS2 product. And, none of the gridded (L3B) products are hooked up to Harmony, so no services are available for those products, even subsetting.

Copy link
Member

@weiji14 weiji14 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like this?

Suggested change
* Data reformatting: users will only get HDF5 files back from the new API.
* Data reformatting: Currently reformatting is not supported for any ICESat-2 products, so users will only get full HDF5 files back from the new Harmony API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stay with something along the lines of "no format transcoding is available" because "full HDF5" sounds like not even subsetting is an option. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Data reformatting: users will only get HDF5 files back from the new API.
* Data reformatting: Currently no format transcoding is available for any ICESat-2 products, so users will only get HDF5 files back from the new Harmony API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we can't push these changes because the development branch is protected (and I don't think we have permissions to override it). I guess we'll just leave this as is, and update the changelog in a v2.0.1 release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this sentence on the GitHub release notes at least - https://github.com/icesat2py/icepyx/releases/tag/v2.0.0. Cheers everyone for making this happen!

@weiji14 weiji14 merged commit da1abd4 into main May 23, 2025
60 of 62 checks passed
@weiji14
Copy link
Member

weiji14 commented May 23, 2025

Note that upload of sdist/wheel to TestPyPI succeeded, but upload to PyPI failed due to an attestation file issue. I've manually downloaded the sdist/wheel from TestPyPI (https://test.pypi.org/project/icepyx/2.0.0/#files) and uploaded it to PyPI at https://pypi.org/project/icepyx/2.0.0/#files (hashsums should match).

Also opened a PR at #687 to fix the publish-to-pypi.yml GitHub Action workflow so this won't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants