Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Feb 12, 2025

Set minimum required Python version to 3.11+, following SPEC 0. Dropping support prior to icepyx v2.x release.

Merge this after #622.

Supersedes #608, addresses #569

@weiji14 weiji14 self-assigned this Feb 12, 2025
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Binder 👈 Launch a binder notebook on this branch for commit e02be9b

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 52ebecf

Binder 👈 Launch a binder notebook on this branch for commit 0fcfb89

Binder 👈 Launch a binder notebook on this branch for commit 3ec0207

Binder 👈 Launch a binder notebook on this branch for commit 9bcdbc5

@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.80%. Comparing base (44e7f4e) to head (9bcdbc5).
Report is 13 commits behind head on development.

❗ There is a different number of reports uploaded between BASE (44e7f4e) and HEAD (9bcdbc5). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (44e7f4e) HEAD (9bcdbc5)
5 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #655      +/-   ##
===============================================
- Coverage        71.88%   66.80%   -5.08%     
===============================================
  Files               37       35       -2     
  Lines             3112     3058      -54     
  Branches           422      422              
===============================================
- Hits              2237     2043     -194     
- Misses             764      928     +164     
+ Partials           111       87      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@betolink
Copy link
Contributor

@weiji14 when do you think we can merge this? not a blocker just wanted to merge your branch into the PR I'm working on but my PR goes to a branch so no worries.

@weiji14
Copy link
Member Author

weiji14 commented Feb 19, 2025

I was gonna wait for @JessicaS11 to merge #622, and then we can merge this to have 3 Python versions supported at least (3.11, 3.12, 3.13).

@JessicaS11
Copy link
Member

#622 is merged; this looks good to me. r.e. #569, should we add a note to the docs around SPEC0 to this PR?

@weiji14 weiji14 marked this pull request as ready for review March 2, 2025 21:25
@weiji14
Copy link
Member Author

weiji14 commented Mar 2, 2025

r.e. #569, should we add a note to the docs around SPEC0 to this PR?

Sure, I can add a note based on the SPEC0 description. Where would you like to put it, somewhere in the contribution pages?

@JessicaS11
Copy link
Member

Where would you like to put it, somewhere in the contribution pages?

Sure - documenting this type of "governance" piece isn't something I've done much of, so if there's a standard best spot devs will look for it please put it there (or create it).

@JessicaS11
Copy link
Member

@weiji14 We're waiting on getting this into the harmony migration PR (#657), so I'm going to merge and we can open a separate PR for #569.

@JessicaS11 JessicaS11 merged commit aeba4eb into development Mar 6, 2025
9 of 10 checks passed
@JessicaS11 JessicaS11 deleted the spec0/python-3.11 branch March 6, 2025 16:55
weiji14 added a commit to regro-cf-autotick-bot/icepyx-feedstock that referenced this pull request May 23, 2025
weiji14 added a commit to conda-forge/icepyx-feedstock that referenced this pull request May 23, 2025
* updated v2.0.0

* MNT: Re-rendered with conda-build 25.4.2, conda-smithy 3.48.1, and conda-forge-pinning 2025.05.22.20.57.09

* Bump python_min to 3.11

Xref icesat2py/icepyx#655

* Convert recipe/meta.yaml to recipe/recipe.yaml

Done using `conda-recipe-manager convert recipe/meta.yaml > recipe/recipe.yaml`.

* MNT: Re-rendered with conda-build 25.4.2, conda-smithy 3.48.1, and conda-forge-pinning 2025.05.23.05.43.47

---------

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants