Skip to content

Conversation

@JessicaS11
Copy link
Member

@JessicaS11 JessicaS11 commented Feb 5, 2025

makes explicit (rather than relying on default) the numpy datetime64 units as "ns" (Xarray default changed and was guessing "us" as more appropriate units instead, causing the _make_np_datetime docstring test (read.py) to fail).

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Binder 👈 Launch a binder notebook on this branch for commit 84c4258

I will automatically update this comment whenever this PR is modified

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.77%. Comparing base (2f1875a) to head (84c4258).
Report is 15 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/read.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2f1875a) and HEAD (84c4258). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (2f1875a) HEAD (84c4258)
5 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #653      +/-   ##
===============================================
- Coverage        71.78%   66.77%   -5.02%     
===============================================
  Files               38       36       -2     
  Lines             3137     3079      -58     
  Branches           426      426              
===============================================
- Hits              2252     2056     -196     
- Misses             775      936     +161     
+ Partials           110       87      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JessicaS11 JessicaS11 changed the title fix failing tests for python 3.12 make np.datetime64 units "ns" explicitly Feb 5, 2025
@JessicaS11 JessicaS11 merged commit 3587c9c into development Feb 5, 2025
7 of 9 checks passed
@JessicaS11 JessicaS11 deleted the fix-failing-tests branch February 5, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants