-
Notifications
You must be signed in to change notification settings - Fork 115
Separate jobs for publishing to TestPyPI and PyPI #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Have a dedicated build distribution job, and split the publish to TestPyPI and PyPI jobs, to workaround attestation file issue. Xref pypa/gh-action-pypi-publish#283
|
I will automatically update this comment whenever this PR is modified
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #687 +/- ##
===============================================
- Coverage 76.38% 76.31% -0.07%
===============================================
Files 42 42
Lines 3205 3205
Branches 404 404
===============================================
- Hits 2448 2446 -2
- Misses 616 617 +1
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wait for Edit: done! |
JessicaS11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for fixing this, @weiji14!
|
No worries, thanks for catching the typo 🙈 Oh, and I don't have permissions to see https://github.com/icesat2py/icepyx/settings/environments, but make sure you're ok with the settings for the |
Have a dedicated build distribution job, and split the publish to TestPyPI and PyPI jobs, to workaround attestation file issue. Xref pypa/gh-action-pypi-publish#283
This should fix the upload to PyPI error seen at https://github.com/icesat2py/icepyx/actions/runs/15200653146/attempts/1#summary-42754052194
I've also ran zizmor (via
zizmor .github/workflows/publish_to_pypi.yml) to verify that the workflow is secure from common security issues.References:
Based on similar PR I made for PyGMT at GenericMappingTools/pygmt#3742