Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented May 23, 2025

Have a dedicated build distribution job, and split the publish to TestPyPI and PyPI jobs, to workaround attestation file issue. Xref pypa/gh-action-pypi-publish#283

This should fix the upload to PyPI error seen at https://github.com/icesat2py/icepyx/actions/runs/15200653146/attempts/1#summary-42754052194

Attestation generation failure:

('The following distributions already have publish attestations:* /github/workspace/dist/icepyx-2.0.0-py3-none-any.whl -> /github/workspace/dist/icepyx-2.0.0-py3-none-any.whl.publish.attestation\n* /github/workspace/dist/icepyx-2.0.0.tar.gz -> /github/workspace/dist/icepyx-2.0.0.tar.gz.publish.attestation',)

You're seeing this because the action attempted to generated PEP 740
attestations for its inputs, but failed to do so.

I've also ran zizmor (via zizmor .github/workflows/publish_to_pypi.yml) to verify that the workflow is secure from common security issues.

References:

Based on similar PR I made for PyGMT at GenericMappingTools/pygmt#3742

Have a dedicated build distribution job, and split the publish to TestPyPI and PyPI jobs, to workaround attestation file issue. Xref pypa/gh-action-pypi-publish#283
@github-actions
Copy link

github-actions bot commented May 23, 2025

Binder 👈 Launch a binder notebook on this branch for commit 7e4e12a

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 9502474

Binder 👈 Launch a binder notebook on this branch for commit b51322b

Binder 👈 Launch a binder notebook on this branch for commit 0a66c1c

Binder 👈 Launch a binder notebook on this branch for commit ecdbda5

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.31%. Comparing base (215a994) to head (ecdbda5).
⚠️ Report is 7 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #687      +/-   ##
===============================================
- Coverage        76.38%   76.31%   -0.07%     
===============================================
  Files               42       42              
  Lines             3205     3205              
  Branches           404      404              
===============================================
- Hits              2448     2446       -2     
- Misses             616      617       +1     
- Partials           141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weiji14 weiji14 mentioned this pull request May 23, 2025
@weiji14
Copy link
Member Author

weiji14 commented May 23, 2025

Wait for development branch to be synced to the main branch according to https://icepyx.readthedocs.io/en/v2.0.0/contributing/release_guide.html#update-the-development-branch-head before merging this.

Edit: done!

@weiji14 weiji14 marked this pull request as ready for review May 23, 2025 20:34
@weiji14 weiji14 requested a review from mfisher87 May 23, 2025 20:38
Copy link
Member

@JessicaS11 JessicaS11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing this, @weiji14!

@JessicaS11 JessicaS11 merged commit 961836c into development Jul 8, 2025
9 of 10 checks passed
@JessicaS11 JessicaS11 deleted the ci/split_publish_to_pypi branch July 8, 2025 14:56
@weiji14
Copy link
Member Author

weiji14 commented Jul 8, 2025

No worries, thanks for catching the typo 🙈

Oh, and I don't have permissions to see https://github.com/icesat2py/icepyx/settings/environments, but make sure you're ok with the settings for the pypi and testpypi environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants