Merged
Conversation
* add suffix to filename * minor changes * ruff
…s-the-modellayers-as-floats-or-str-depending-on-nan-values-in-input make sure layer dtype is float or int
* Empty lakeout column leads error in lake package construction Lakeout may be empty when after discretizing your lake shapes, the shapes with a lakeout may be outside of your extent. * Fixed newly introduced bug in lake.py Thanks Onno
PRT backward with a disv grid
Cleanup project settings
* [WIP] Initial commit supporting connected wells in MAW * Add group handling to maw_from_df for multi-aquifer wells - Introduced a new optional parameter 'group' to allow grouping of wells. - Updated documentation to reflect changes in well rate handling for grouped wells. - Added validation to ensure unique DataFrame index and consistent flow rates within groups. * Support hk_skin and radius_skin arguments * Fix indexing in maw_from_df to use 'cellid' from well_group * Add tests for maw_from_df with skin and grouped wells handling * Formatting in maw_from_df function
* Add uniform grid handling and fillnan functionality for structured grids * Private function at the bottom * Not needed to accesss .values * Speed up fillnan functions * Refactor fillnan functions for improved performance and add support for linear interpolation method in tests * formatting * Fix strictness in zip function for vertex grid handling in vertex_da_to_ds * Enhance fillnan_da tests * Suggestions made by Onno * Only pass relevant gridvalues to griddata when interpolating nan values * formatting * Addressing comments of Onno * Improve fillnan_da_vertex_grid function and tests for better coordinate handling * fillnan_da_structured_grid to create deep copies of DataArrays to prevent memory sharing issues. Update tests for fillnan_da_vertex_grid to ensure proper handling of coordinates and validate results.
lakeout can be of type string, in which case isna() is not sufficient.
* add plot_wells method to datasetcrosssection * add automatic sorting * ruff * add locations to mapax * comments Ruben * small fixes
Add issue templates
So also handle the case when there are no layers to be combined anymore
* Update lake.py * Make sure current models do not give different results * Update test_013_surface_water.py * Remove a wrong logger statement
* Add parameters `add_stn_dimensions` and `to_model_time` to `nlmod.read.knmi.get_recharge()` * Also allow generation of rch-package from stations data and from floats * Implement new meteorological data structure for evt and uzf, fix tests, and remove warnings * Move internal method _get_meteo_da_from_input lower in file * fix test * Make recharge_stn and evaporation_stn integer-arrays
* Improve hfb methods * Two minor changes in surface_water and modpath * Update waterboard sources * Solve failing tests and improve docstring of `nlmod.gwf.hfb.plot_hfb` * rename parameter `gwf` to `modelgrid` in `nlmod.gwf.plot_hfb`
So users can bypass issue #522
Assertions in dataframe_to_flopy_timeseries now include custom error messages for NaN values and incorrect time index types, improving debugging and error clarity.
there was a new file with BGT-bronhouders, but there were no changes ("Geen wijzigingen")
…_of_z` (#524) * Fix issue 523 * Add extra tests
* Clean dependencies * Fix codacy errors and remove pinned numpy and netcdf versions * Update util.py * try to fix last codacy issue... * Move import_hydropandas to util.py
* Restructure documentation and add new sections Documentation was reorganized into new sections: data sources, utilities, workflows, and advanced stress packages. Example notebooks were moved to corresponding subfolders, and new .rst files were added for each section. A new notebook on meteorological data was added. The index.rst was updated to reflect the new structure. Metadata in several notebooks was cleaned up, and a script to clear notebook outputs was introduced. * Update data sources docs and move cache example Expanded the list of available data sources in the documentation for greater clarity. Moved cache_example.py from docs/examples to docs/utilities for better organization. * Update and add documentation notebooks Revised several documentation notebooks to improve clarity, update code, and remove author credits and images. Added a new workflow notebook for aggregating surface water features into model cells (taken from surface-water-notebook). Updated example and utility notebooks for consistency and improved instructions. Adjusted references to model workspace paths and improved section headings in meteorological data documentation. * Update documentation notebooks and metadata Refactored example and workflow notebooks to remove unused script_path arguments from function calls and cleaned up markdown formatting. Updated kernelspec and language_info metadata in relevant notebooks. Minor improvements to documentation text for clarity. * Update documentation notebooks and reorganize workflows * Update waterboard level areas URL for Rivierenland and fix two other notebooks * fix notebook observations and improve gettings_started.rst * Add logo Artesia and improve logo nlmod * Update rst files of documentation * Update rst files * Update logo assets and documentation * handle comments from @dbrakenhoff * some changes that were forgotten to be saved * Try myst_nb instead of nbsphinx * Do not fix packages for rtd * Remove tqdm output from documentation and vertical space between lines in code blocks * Revert "Remove tqdm output from documentation and vertical space between lines in code blocks" This reverts commit 51670ee. * Enable stream merging in notebook execution Set nb_merge_streams to True in Sphinx configuration to merge output streams during notebook execution. * Monkey-patch tqdm to disable progress bars in docs Added a noop implementation for tqdm and monkey-patched common variants in docs/conf.py to prevent progress bars from appearing during documentation builds. * Add custom CSS for scrollable DataFrames in docs Introduces a custom.css file to make pandas DataFrames horizontally scrollable in documentation. Updates conf.py to include the new CSS and switches TQDM disabling to use an environment variable for cleaner configuration. * environmental variable TQDM_DISABLE is set in readthedocs settings * Update custom.css * Do not who progressbar from dask * minor improvements * improve notebooks * Remove dask progressbar from documentation
* Add hourly_precision And add `_resample_df_to_model_time`, and also call this when to `add_stn_dimensions=True` * Minor fix of docstring * Add lake notebook * more small fixes to the documentation * Update some url's of waterboards * Catch data not available at KNMI * Update water board data * Update 01_lake.ipynb
* Add AHN6 support and flexible AHN data configuration Introduces support for AHN6 data, including a new download_ahn6 function and updated configuration management via get_configuration(). Refactors AHN download functions to allow selection by version, resolution, data kind, and tile size, defaulting to config-based URLs when identifier is not provided. Updates docstrings for clarity and adds internal helpers for tile-based downloads. * Fix tests * Avoid gdal-warnings * Remove legcay ahn-methods, as these webservices are not online anymore * Remove unused arcrest import and dead code in ahn.py Eliminated the unused 'arcrest' import and removed the unused internal function '_download_and_combine_tiles' * Remove unused imports * Rename argument `km` to `tile_size`, from boolean to string And add some tests * Fix bugs in notebooks * Minor changes to notebooks * Fix warnings in modpath notebooks * Implement suggestions from @OnnoEbbens * rename `get_file` to `get_fname` and fix typo * Add _delete_tiles_from_config_in_data
* minor fixes and changes * reinstate fix
OnnoEbbens
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.