Do not set meteorological data to 0 at lakes anymore#514
Merged
rubencalje merged 4 commits intodevfrom Nov 18, 2025
Merged
Conversation
OnnoEbbens
approved these changes
Oct 9, 2025
Collaborator
Author
|
Tests fail unrelated to this PR |
rubencalje
deleted the
Do-not-set-meteorological-data-to-0-at-lakes-anymore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #497.
This PR adds the method
copy_meteorological_data_from_dswhich does not set the meteorological data in ds at the lake-locations to 0 anymore. The methodclip_meteorological_data_from_dsis still available for backwards compatibility, but a warning is shown to the user, that this method is deprecated.This change is only important when lakes fall dry, as MODFLOW 6 sets the evaporation and precipitation from the RCH and EVT packages to 0 in cells below active lakes already. When this data is set to 0 in the model dataset as well, there is no rainfall or evaporation applied to the cell when the lake falls dry, which is not what we want.