Merged
Conversation
dbrakenhoff
reviewed
Dec 9, 2025
nlmod/read/bro.py
Outdated
| _description_ | ||
| """ | ||
| try: | ||
| import hydropandas as hpd |
Collaborator
There was a problem hiding this comment.
why not move _import_hydropandas to utils as well and use it here?
Collaborator
Author
There was a problem hiding this comment.
Good suggestion!
dbrakenhoff
approved these changes
Dec 9, 2025
Collaborator
dbrakenhoff
left a comment
dbrakenhoff
left a comment
There was a problem hiding this comment.
Looks good, one comment, but no big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans the dependencies. It removes the installation-section on the readme-page, as this is also on the readthedocs-page, which is hard to maintain.
Has to do with issue #516, but more work needed to solve this issue.