Skip to content

make sure layer dtype is float or int#496

Merged
martinvonk merged 4 commits intodevfrom
495-get_modellayers_indexer-returns-the-modellayers-as-floats-or-str-depending-on-nan-values-in-input
Jul 29, 2025
Merged

make sure layer dtype is float or int#496
martinvonk merged 4 commits intodevfrom
495-get_modellayers_indexer-returns-the-modellayers-as-floats-or-str-depending-on-nan-values-in-input

Conversation

@OnnoEbbens
Copy link
Collaborator

No description provided.

@OnnoEbbens
Copy link
Collaborator Author

So the title is now super confusing because I made sure the dtype is str (or float if there are nan's).

@OnnoEbbens OnnoEbbens marked this pull request as draft July 23, 2025 08:33
@OnnoEbbens OnnoEbbens requested a review from martinvonk July 23, 2025 08:33
@OnnoEbbens OnnoEbbens marked this pull request as ready for review July 23, 2025 08:33
@OnnoEbbens
Copy link
Collaborator Author

I fixed the test with the new default drop_nan_layers=True. It seems such a small change that I wonder why @dbrakenhoff has not done it yet. That makes me a bit wary that I don't see the full picture and everything will break now.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in NHFLO Jul 29, 2025
@martinvonk martinvonk merged commit 736bc46 into dev Jul 29, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in NHFLO Jul 29, 2025
@OnnoEbbens OnnoEbbens deleted the 495-get_modellayers_indexer-returns-the-modellayers-as-floats-or-str-depending-on-nan-values-in-input branch August 12, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_modellayers_indexer returns the modellayers as floats or str depending on nan values in input

2 participants