Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Fix test button check for iOS 15 #4088

Merged
fluttergithubbot merged 1 commit into from
Jun 24, 2021
Merged

[url_launcher] Fix test button check for iOS 15 #4088

fluttergithubbot merged 1 commit into from
Jun 24, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 23, 2021

On iOS 15 the ShareButton button identifier has been renamed to MoreOptionsButton. Switch the check to the common Share label that works on both versions.

Fixes flutter/flutter#85161

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
jmagman
jmagman commented Jun 23, 2021
View reviewed changes
packages/url_launcher/url_launcher/example/ios/RunnerUITests/URLLauncherUITests.m
];
for (NSString* buttonName in buttonNames) {
XCUIElement* button = app.buttons[buttonName];
if (![button waitForExistenceWithTimeout:30.0]) {
Copy link
Member Author

@jmagman jmagman Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had copied this pattern from some other existing test, but I think just the XCTAssertTrue is less busy.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 24, 2021
@fluttergithubbot fluttergithubbot merged commit 09e2d5c into flutter:master Jun 24, 2021
@jmagman jmagman deleted the url-launch-test branch June 24, 2021 21:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
@engine-flutter-autoroll
09e2d5c [url_launcher] Fix test button check for iOS 15 (flutter/plug…
da22830 
…ins#4088)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2021
@engine-flutter-autoroll
09e2d5c [url_launcher] Fix test button check for iOS 15 (flutter/plug…
62eee7f 
…ins#4088)
Ralph-Li pushed a commit to Insight-Timer/plugins that referenced this pull request Jul 1, 2021
@adad184
Merge branch 'upstream_v0_8_1+3'
75d8b60 
* upstream_v0_8_1+3: (99 commits)
  [image_picker] Fixed IOException when cache directory is removed (flutter#4117)
  [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096)
  Add Basic Junit Tests to some plugins (flutter#4108)
  [image_picker]Update example app (flutter#4103)
  [flutter_plugin_tools] Restructure version-check (flutter#4111)
  Split some Cirrus script steps (flutter#4112)
  [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105)
  [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110)
  [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085)
  [flutter_plugin_tools] release 0.3.0 (flutter#4109)
  Migrate command, add failure test, remove skip (flutter#4106)
  Don't install cocoapods; use the version in the image (flutter#4104)
  [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084)
  Add release status badge to README (flutter#4102)
  Build all iOS example apps on current Flutter stable (flutter#4101)
  [url_launcher] Fix test button check for iOS 15 (flutter#4088)
  Update .ci.yaml documentation link (flutter#4090)
  [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089)
  [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068)
  [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100)
  ...

# Conflicts:
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@jmagman @amantoux
[url_launcher] Fix test button check for iOS 15 (flutter#4088)
3f80c63
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[url_launcher] Fix test button check for iOS 15 (flutter#4088)
9a61da6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

cla: yes p: url_launcher platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

-[URLLauncherUITests testLaunch] fails on iOS 15 beta 1

3 participants

@jmagman @stuartmorgan-g @fluttergithubbot