This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Build all iOS example apps on current Flutter stable #4101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: battery
Member
Author
|
Should I update the |
jmagman
commented
Jun 24, 2021
| /* Begin PBXBuildFile section */ | ||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; | ||
| 3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; }; | ||
| 3B80C3941E831B6300D905FE /* App.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3B80C3931E831B6300D905FE /* App.framework */; }; |
| /* Begin XCBuildConfiguration section */ | ||
| 97C147031CF9000F007C117D /* Debug */ = { | ||
| isa = XCBuildConfiguration; | ||
| baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */; |
| <Workspace | ||
| version = "1.0"> | ||
| <FileRef | ||
| location = "group:Runner.xcodeproj"> |
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" thin"; | ||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" embed_and_thin"; |
| // Generated file. Do not edit. | ||
| // | ||
|
|
||
| // clang-format off |
| shellPath = /bin/sh; | ||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" thin"; | ||
| }; | ||
| 4096151B6BA12D6D4D7DD96A /* [CP] Embed Pods Frameworks */ = { |
Member
Author
There was a problem hiding this comment.
The Objective-C Podfiles are set up to use libraries, not frameworks. CocoaPods is removing the build step that embeds the frameworks into the app.
Member
Author
|
Hm, the formatter doesn't like the generated empty -
-void RegisterPlugins(flutter::PluginRegistry* registry) {
-}
+void RegisterPlugins(flutter::PluginRegistry* registry) {} |
Member
Author
I reverted the Windows and Linux project changes, sticking to just iOS for this PR. |
Contributor
Yeah, this is why we turned off auto-format in the templates recently on master. |
jmagman
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2021
Ralph-Li
pushed a commit
to Insight-Timer/plugins
that referenced
this pull request
Jul 1, 2021
* upstream_v0_8_1+3: (99 commits) [image_picker] Fixed IOException when cache directory is removed (flutter#4117) [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096) Add Basic Junit Tests to some plugins (flutter#4108) [image_picker]Update example app (flutter#4103) [flutter_plugin_tools] Restructure version-check (flutter#4111) Split some Cirrus script steps (flutter#4112) [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105) [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110) [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085) [flutter_plugin_tools] release 0.3.0 (flutter#4109) Migrate command, add failure test, remove skip (flutter#4106) Don't install cocoapods; use the version in the image (flutter#4104) [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084) Add release status badge to README (flutter#4102) Build all iOS example apps on current Flutter stable (flutter#4101) [url_launcher] Fix test button check for iOS 15 (flutter#4088) Update .ci.yaml documentation link (flutter#4090) [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089) [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068) [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100) ... # Conflicts: # packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
build-examples --ipaon Flutter 2.2.2 (current stable). Allow the Flutter tool and CocoaPods to migrate project files.This will reduce working copy changes when the example projects are built for testing.
Pre-launch Checklist
dart format.)[shared_preferences]///).