This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Don't install cocoapods during CI runs #4104
Merged
stuartmorgan-g
merged 1 commit into
flutter:master
from
stuartmorgan-g:remove-install-cocoapods
Jun 25, 2021
Merged
Don't install cocoapods during CI runs #4104
stuartmorgan-g
merged 1 commit into
flutter:master
from
stuartmorgan-g:remove-install-cocoapods
Jun 25, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Testing to see if the image's version is new enough for us. |
Contributor
Author
|
I'm still not sure why this step has been flakily failing over the last day or two, but it looks like we can just skip it. If at some point we need a newer version we can re-add this. |
jmagman
approved these changes
Jun 25, 2021
Member
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was ensuring the most recent version of CocoaPods was installed. In the past sometimes the Cirrus image was running something older. #3347
LGTM to mitigate whatever is flaking. If Flutter every ups its minimum required CocoaPods version and the image doesn't have it, you may need to re-add this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2021
Ralph-Li
pushed a commit
to Insight-Timer/plugins
that referenced
this pull request
Jul 1, 2021
* upstream_v0_8_1+3: (99 commits) [image_picker] Fixed IOException when cache directory is removed (flutter#4117) [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096) Add Basic Junit Tests to some plugins (flutter#4108) [image_picker]Update example app (flutter#4103) [flutter_plugin_tools] Restructure version-check (flutter#4111) Split some Cirrus script steps (flutter#4112) [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105) [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110) [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085) [flutter_plugin_tools] release 0.3.0 (flutter#4109) Migrate command, add failure test, remove skip (flutter#4106) Don't install cocoapods; use the version in the image (flutter#4104) [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084) Add release status badge to README (flutter#4102) Build all iOS example apps on current Flutter stable (flutter#4101) [url_launcher] Fix test button check for iOS 15 (flutter#4088) Update .ci.yaml documentation link (flutter#4090) [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089) [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068) [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100) ... # Conflicts: # packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image should already have cocoapods installed.
Pre-launch Checklist
dart format.)[shared_preferences]///).