Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Fix test button check for iOS 15 #4088

Merged
fluttergithubbot merged 1 commit into from
Jun 24, 2021
Merged

[url_launcher] Fix test button check for iOS 15 #4088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Fix test button check for iOS 15.

## 6.0.7

* Update the README to describe a workaround to the `Uri` query
Expand Down
14 changes: 4 additions & 10 deletions packages/url_launcher/url_launcher/example/ios/RunnerUITests/URLLauncherUITests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,13 @@ - (void)testLaunch {
];
for (NSString* buttonName in buttonNames) {
XCUIElement* button = app.buttons[buttonName];
if (![button waitForExistenceWithTimeout:30.0]) {
Copy link
Member Author

@jmagman jmagman Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had copied this pattern from some other existing test, but I think just the XCTAssertTrue is less busy.

os_log_error(OS_LOG_DEFAULT, "%@", app.debugDescription);
XCTFail(@"Failed due to not able to find %@ button", buttonName);
}
XCTAssertTrue([button waitForExistenceWithTimeout:30.0]);
XCTAssertEqual(app.webViews.count, 0);
[button tap];
XCUIElement* webView = app.webViews.firstMatch;
if (![webView waitForExistenceWithTimeout:30.0]) {
os_log_error(OS_LOG_DEFAULT, "%@", app.debugDescription);
XCTFail(@"Failed due to not able to find webview");
}
XCTAssertTrue(app.buttons[@"ForwardButton"].exists);
XCTAssertTrue(app.buttons[@"ShareButton"].exists);
XCTAssertTrue([webView waitForExistenceWithTimeout:30.0]);
XCTAssertTrue([app.buttons[@"ForwardButton"] waitForExistenceWithTimeout:30.0]);
XCTAssertTrue(app.buttons[@"Share"].exists);
XCTAssertTrue(app.buttons[@"OpenInSafariButton"].exists);
[app.buttons[@"Done"] tap];
}
Expand Down