-
Notifications
You must be signed in to change notification settings - Fork 5.5k
remove Docker EULA licensing which isn't relevant #12829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed to a subscription model Signed-off-by: Nicolas De Loof <[email protected]>
|
cc @rickredondo |
LICENSE
Outdated
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] | ||
| Copyright 2025 Docker, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be filled in in the license; this section is an example how to apply the license (which is done by adding the headers to the source code and/or a NOTICE file).
We also don't own the copyright, so this would be incorrect in either case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used https://github.com/docker/cli/blob/master/LICENSE#L179 for reference 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know! And it's been wrong since forever. Still want to change that (and apply proper license headers), but I may need approval from legal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TL;DR is that (for Apache 2)
- Adding a LICENSE file to the repository does NOT apply the license (the LICENSE file is only there for convenience, and not even strictly neeeded; it's just so that those using the software don't have to download it from the apache website)
- The "copyright" section in the Apache 2 LICENSE file is basically part of the documentation; the section above it literally describes "how to apply the license", which mentions "to apply the license, take the snippet below, fill in the copyright lines, and add it to each and every file that the license must be applied to". Also add a NOTICE file to document other legal constraints or licenses (such as patents, licenses of dependencies used (go.mod / vendor))
- Given that we DON'T have a CLA, no copyright is transferred, which means that the copyright is owned by the "AUTHOR" of each line of code.
- ☝️ and because mentioning each individual author ... for each file .. would be a bit lengthy, it's common to use "The Authors" (or "The
<insert project name>Authors") as copyright holder. - ☝️ and the copyright "year" is implied from year of publication for each line of code, which basically is "date it was pushed to GitHub", so the copyright-years will be different for each file
- ☝️ given that source is in source-control, it's therefore usually OK to omit copyright year(s) altogether, as it can be deducted from git-history. But alternatively, it's not uncommon to add a "first year of publication of the code (as a whole)"
Also see;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the above; this is also why there's an AUTHORS file in the Moby (and other) repositories, as that effectively lists the copyright-holders; https://github.com/moby/moby/blob/master/AUTHORS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped second commit
| done | ||
| - | ||
| name: License | ||
| run: cp packaging/* ./bin/release/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one be swapped for the top-level LICENSE, or was a license already added as part of one of the steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK compose is the only docker artifact where we include a LICENSE file with built artifact (for legacy reasons)
Licensing is already set by github project and source code archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right; I wasn't sure if folks would expect it to be there.
I know / recall it's included in the .deb and/or .rpm packages but that's probably separate from this?
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.36.0` -> `v2.36.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.36.1`](https://github.com/docker/compose/releases/tag/v2.36.1) [Compare Source](docker/compose@v2.36.0...v2.36.1) #### What's Changed ##### ✨ Improvements - Provider.options can be an array by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12819 - Set provider environment by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12817 - Add support of `debug` messages in the communication between Compose … by [@​glours](https://github.com/glours) in docker/compose#12826 - Introduce config `--lock-image-digests` by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12843 ##### 🐛 Fixes - Skip push step for provider services by [@​glours](https://github.com/glours) in docker/compose#12818 - Provider info by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12820 - Append `.exe` to provider name doing executable lookup on windows by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12832 - Fix quiet option when using COMPOSE_BAKE=1 by [@​AnvarU](https://github.com/AnvarU) in docker/compose#12838 - Do not throw an error on build with provider services by [@​glours](https://github.com/glours) in docker/compose#12842 - Report cancelled pull after another one failed by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12840 - Ensure build dependencies are enabled by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12824 ##### 🔧 Internal - Simplification by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12811 - Remove Docker EULA licensing which isn't relevant by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12829 - Remove convert alias from config command by [@​glours](https://github.com/glours) in docker/compose#12850 ##### ⚙️ Dependencies - Build(deps): bump github.com/containerd/containerd/v2 from 2.0.5 to 2.1.0 by [@​dependabot](https://github.com/dependabot) in docker/compose#12813 - Build(deps): bump google.golang.org/grpc from 1.72.0 to 1.72.1 by [@​dependabot](https://github.com/dependabot) in docker/compose#12837 - Bump compose-go to v2.6.3 by [@​glours](https://github.com/glours) in docker/compose#12849 **Full Changelog**: docker/compose@v2.36.0...v2.36.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
There's no Docker EULA anymore since Docker switched to a subscription model
fix #12280